controller: Fix performance-move-const-arg
```
/home/andrew/src/openbmc/phosphor-led-sysfs/build/../controller.cpp:97:17: error: std::move of the const expression has no effect; remove std::move() [performance-move-const-arg,-warnings-as-errors]
auto path = std::move((options)["path"]);
^~~~~~~~~~ ~
```
Change-Id: I5a26c0b9fa7fcd3d07a2495eeeb5cd0a1e089ceb
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
diff --git a/controller.cpp b/controller.cpp
index c22be0c..723fd7b 100644
--- a/controller.cpp
+++ b/controller.cpp
@@ -94,12 +94,13 @@
auto options = phosphor::led::ArgumentParser(argc, argv);
// Parse out Path argument.
- auto path = std::move((options)["path"]);
- if (path.empty())
+ if (options["path"].empty())
{
exitWithError("Path not specified.", argv);
}
+ auto path = options["path"];
+
// If the LED has a hyphen in the name like: "one-two", then it gets passed
// as /one/two/ as opposed to /one-two to the service file. There is a
// change needed in systemd to solve this issue and hence putting in this