sdbusplus: object: don't use 'bool' argument constructor
`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8f609948cb7ce65f3adb611ddd6eafa0bf4f486a
diff --git a/physical.hpp b/physical.hpp
index 4242952..7a3c912 100644
--- a/physical.hpp
+++ b/physical.hpp
@@ -16,12 +16,16 @@
/** @brief De-assert value */
constexpr unsigned long DEASSERT = 0;
+namespace
+{
+using PhysicalIfaces = sdbusplus::server::object_t<
+ sdbusplus::xyz::openbmc_project::Led::server::Physical>;
+}
+
/** @class Physical
* @brief Responsible for applying actions on a particular physical LED
*/
-class Physical :
- public sdbusplus::server::object::object<
- sdbusplus::xyz::openbmc_project::Led::server::Physical>
+class Physical : public PhysicalIfaces
{
public:
Physical() = delete;
@@ -43,10 +47,8 @@
*/
Physical(sdbusplus::bus::bus& bus, const std::string& objPath,
SysfsLed& led, const std::string& color = "") :
-
- sdbusplus::server::object::object<
- sdbusplus::xyz::openbmc_project::Led::server::Physical>(
- bus, objPath.c_str(), true),
+ PhysicalIfaces(bus, objPath.c_str(),
+ PhysicalIfaces::action::defer_emit),
led(led)
{
// Suppose this is getting launched as part of BMC reboot, then we