tree 4c87190c342fcaf340e9e140a376db0d533e36ad
parent c41bf5b7fdf4599101fe31e7d2e998aebfca7f92
author Andrew Jeffery <andrew@aj.id.au> 1527132930 +0930
committer Andrew Jeffery <andrew@aj.id.au> 1552885024 +1030

controller: Avoid pessimistic moves

clang-6.0 reports that some of the moves prevent further optimisations, so
remove them.

$ make
make  all-am
make[1]: Entering directory '/home/andrew/src/openbmc/phosphor-led-sysfs'
  CXX      controller.o
controller.cpp:60:12: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
    path = std::move(DEVPATH + name);
           ^
controller.cpp:60:12: note: remove std::move call here
    path = std::move(DEVPATH + name);
           ^~~~~~~~~~              ~
controller.cpp:75:16: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
    auto bus = std::move(sdbusplus::bus::new_default());
               ^
controller.cpp:75:16: note: remove std::move call here
    auto bus = std::move(sdbusplus::bus::new_default());
               ^~~~~~~~~~                             ~
2 errors generated.
Makefile:761: recipe for target 'controller.o' failed
make[1]: *** [controller.o] Error 1
make[1]: Leaving directory '/home/andrew/src/openbmc/phosphor-led-sysfs'
Makefile:617: recipe for target 'all' failed
make: *** [all] Error 2

Change-Id: I3da6415def4ab183cc9f6c5e176e8bb3666cf1b7
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>