commit d70103d881562c657b0c750b04b099375b095a8a
author Andrew Jeffery <andrew@aj.id.au> Fri Feb 03 16:06:04 2023 +1030
committer Andrew Jeffery <andrew@aj.id.au> Tue Feb 07 14:37:02 2023 +1030
tree c8efecffea6366ebf4e9ee7fa4ed5dab5a05cead
parent f9e6cd3a3efaf03dbf88b5eb73a9253c1ce0c780

argument: Fix cppcoreguidelines-avoid-non-const-global-variables

```
../argument.cpp:31:29: error: variable 'optionstr' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
const char* ArgumentParser::optionstr = "p:?h";
                            ^
```

Change-Id: I8518db5525e0f67c8f263079a9389621094249bf
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

argument.cpp

diff --git a/argument.cpp b/argument.cpp
index c7d6043..2720da9 100644
--- a/argument.cpp
+++ b/argument.cpp
@@ -28,7 +28,6 @@
 
 const std::string ArgumentParser::true_string = "true";
 
-const char* ArgumentParser::optionstr = "p:?h";
 const option ArgumentParser::options[] = {
     {"path", required_argument, nullptr, 'p'},
     {"help", no_argument, nullptr, 'h'},

argument.hpp

diff --git a/argument.hpp b/argument.hpp
index 040b022..c1a80d2 100644
--- a/argument.hpp
+++ b/argument.hpp
@@ -47,7 +47,7 @@
     static const option options[];
 
     /** @brief optstring as needed by getopt_long */
-    static const char* optionstr;
+    static inline const char* optionstr = "p:?h";
 };
 
 } // namespace led