commit e5c40feae02560f56790457be1c2e289ccd0ce6f
author Andrew Jeffery <andrew@aj.id.au> Fri May 25 15:27:18 2018 +0930
committer Andrew Jeffery <andrew@aj.id.au> Mon Apr 08 13:48:50 2019 +0930
tree 668e342a0f5799623bc5235da61d623048944aa9
parent 30726a0c584e77677f64d5f06f8588b1b9881532

physical: 'frequency' is really periodicity

Change-Id: I1007d2a7104fa07351c89c52a860cde83b2d509c
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

physical.cpp

diff --git a/physical.cpp b/physical.cpp
index 3290661..0de2a53 100644
--- a/physical.cpp
+++ b/physical.cpp
@@ -41,8 +41,8 @@
         auto delayOff = led.getDelayOff();
 
         // Calculate frequency and then percentage ON
-        frequency = delayOn + delayOff;
-        auto factor = frequency / 100;
+        periodMs = delayOn + delayOff;
+        auto factor = periodMs / 100;
         auto dutyOn = delayOn / factor;
 
         // Update.
@@ -50,10 +50,10 @@
     }
     else
     {
-        // This is hardcoded for now. This will be changed to this->frequency()
-        // when frequency is implemented.
+        // This is hardcoded for now. This will be changed to this->period()
+        // when configurable periodicity is implemented.
         // TODO
-        frequency = 1000;
+        periodMs = 1000;
 
         // LED is either ON or OFF
         auto brightness = led.getBrightness();
@@ -137,11 +137,11 @@
 
     // Write DutyON. Value in percentage 1_millisecond.
     // so 50% input becomes 500. Driver wants string input
-    auto percentage = frequency / 100;
-    led.setDelayOn(dutyOn * percentage);
+    auto factor = periodMs / 100;
+    led.setDelayOn(dutyOn * factor);
 
     // Write DutyOFF. Value in milli seconds so 50% input becomes 500.
-    led.setDelayOff((100 - dutyOn) * percentage);
+    led.setDelayOff((100 - dutyOn) * factor);
     return;
 }