log_manager: remove redundant createWithFFDC

Fold the functionality of creating an event entry with FFDC appended
into a common implementation to avoid code duplication and to ease
further extension and maintainability.

Build-tested with 'openpower-pel-extension' enabled.

Change-Id: I0f8151b782bf42cc7bc0981e58f6ab1e3cda080c
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
diff --git a/log_manager.cpp b/log_manager.cpp
index cf7ef60..4cdbc4e 100644
--- a/log_manager.cpp
+++ b/log_manager.cpp
@@ -620,19 +620,8 @@
 }
 
 void Manager::create(const std::string& message, Entry::Level severity,
-                     const std::map<std::string, std::string>& additionalData)
-{
-    // Convert the map into a vector of "key=value" strings
-    std::vector<std::string> ad;
-    metadata::associations::combine(additionalData, ad);
-
-    createEntry(message, severity, ad);
-}
-
-void Manager::createWithFFDC(
-    const std::string& message, Entry::Level severity,
-    const std::map<std::string, std::string>& additionalData,
-    const FFDCEntries& ffdc)
+                     const std::map<std::string, std::string>& additionalData,
+                     const FFDCEntries& ffdc)
 {
     // Convert the map into a vector of "key=value" strings
     std::vector<std::string> ad;