tree e91e25b42176474a0098634facee6afa6c159397
parent 7ba6544e661185bcd8be5f58a0730e51e96a6aaa
author Patrick Williams <patrick@stwcx.xyz> 1619101607 -0500
committer Patrick Williams <patrick@stwcx.xyz> 1619102069 -0500

openpower-pels: json_utils: fix crash on invalid format string

The `getNumberString` function previously crashed if an invalid
format string was passed, because it would attempt to construct
a std::string from a nullptr.  There was even a test case that
confirmed that the code crashed via a SIGSEGV!

AddressSanitizer, which is ran on all of our meson-based CIs,
does not allow this kind of behavior.  Change `getNumberString`
so it throws a `std::invalid_argument` instead of crashing, which
itself might result in a `std::terminate` if the exception is
uncaught, but is at least acceptable behavior in the eyes of the
AddressSanitizer (and mine as well).

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I06d25edc2ddf552169383e03595426bb065425be