commit 2ccdcef99732e8f1f6bccd36f30c175c98db27d8
author Sumit Kumar <sumit_kumar@in.ibm.com> Sat Jul 31 10:04:58 2021 -0500
committer Matt Spinler <spinler@us.ibm.com> Fri Aug 06 15:28:09 2021 +0000
tree 24a3e80d67ccf743e2e11f7e869ff9e94c0e2253
parent 7f1ec94d55bec2f482fa8169c2df6aebdc9ccf0c

PEL: Guard against hostboot sending down duplicate PEL Ids

This commit is to guard against hostboot sending down PEL Id
that we already have in our repository. This caused PEL to
get orphaned in the filesystem without a corresponding valid
openbmc event log Id.
The action is to move such PELs to archive folder.

Signed-off-by: Sumit Kumar <sumit_kumar@in.ibm.com>
Change-Id: I46bb865b4b87ec0b59f362e3f79a1b5a6710a45c

extensions/openpower-pels/manager.cpp

diff --git a/extensions/openpower-pels/manager.cpp b/extensions/openpower-pels/manager.cpp
index 3387970..db2e2d6 100644
--- a/extensions/openpower-pels/manager.cpp
+++ b/extensions/openpower-pels/manager.cpp
@@ -127,7 +127,6 @@
 
 void Manager::addPEL(std::vector<uint8_t>& pelData, uint32_t obmcLogID)
 {
-
     auto pel = std::make_unique<openpower::pels::PEL>(pelData, obmcLogID);
     if (pel->valid())
     {
@@ -137,6 +136,22 @@
         {
             pel->assignID();
         }
+        else
+        {
+            const Repository::LogID id{Repository::LogID::Pel(pel->id())};
+            auto result = _repo.hasPEL(id);
+            if (result)
+            {
+                log<level::WARNING>(
+                    fmt::format("Duplicate HostBoot PEL Id {:#X} found; "
+                                "moving it to archive folder",
+                                pel->id())
+                        .c_str());
+
+                _repo.archivePEL(*pel);
+                return;
+            }
+        }
 
         // PELs created by others still need this field set by us.
         pel->setCommitTime();