commit 2edce4e2b9059d37f50f28c91d4bc5a4cd760e21
author Matt Spinler <spinler@us.ibm.com> Wed Jan 17 11:13:51 2024 -0600
committer Matt Spinler <spinler@us.ibm.com> Tue Jan 23 16:11:32 2024 +0000
tree ff2980db8b8e3b88c5476c2e89ad9f965e15d91b
parent f16666164a3e266cc8c0a17f3f1ad34f838d5e49

PEL: Use raw procedure names in PEL msg reg

Start using the raw maintenance procedure names in the PEL message
registry, such as BMC0001, instead of the enum values, such as
'bmc_firmware'.  This way, the script that generates documentation can
list the procedure in the section for that PEL.  This was requested by
the support team.

Note that there is still one user of the enums - the checkstop analysis
code uses them when it creates callouts by passing in them via JSON user
data files.

There are pointers added to the README and schema to find the available
procedures and their descriptions.

Tested:
- The unit tests still work which verify the callout contents when PEL
  callouts are created via the message registry.
- Also manually verified PEL procedure callouts look correct when
  created from the message registry.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I3e8416956120d4dae1ff40592fd0df4f0285d072

test/openpower-pels/pel_manager_test.cpp

diff --git a/test/openpower-pels/pel_manager_test.cpp b/test/openpower-pels/pel_manager_test.cpp
index ee44c34..f1bc57a 100644
--- a/test/openpower-pels/pel_manager_test.cpp
+++ b/test/openpower-pels/pel_manager_test.cpp
@@ -243,7 +243,7 @@
             "Callouts": [
                 {
                     "CalloutList": [
-                        {"Priority": "high", "Procedure": "bmc_code"},
+                        {"Priority": "high", "Procedure": "BMC0001"},
                         {"Priority": "medium", "SymbolicFRU": "service_docs"}
                     ]
                 }

test/openpower-pels/registry_test.cpp

diff --git a/test/openpower-pels/registry_test.cpp b/test/openpower-pels/registry_test.cpp
index 2f715bb..1fb78b0 100644
--- a/test/openpower-pels/registry_test.cpp
+++ b/test/openpower-pels/registry_test.cpp
@@ -458,7 +458,7 @@
             [
                 {
                     "Priority": "medium",
-                    "Procedure": "bmc_code"
+                    "Procedure": "BMC0001"
                 },
                 {
                     "Priority": "low",
@@ -503,7 +503,7 @@
         EXPECT_EQ(callouts.size(), 2);
         EXPECT_EQ(callouts[0].priority, "medium");
         EXPECT_EQ(callouts[0].locCode, "");
-        EXPECT_EQ(callouts[0].procedure, "bmc_code");
+        EXPECT_EQ(callouts[0].procedure, "BMC0001");
         EXPECT_EQ(callouts[0].symbolicFRU, "");
         EXPECT_EQ(callouts[1].priority, "low");
         EXPECT_EQ(callouts[1].locCode, "P3-C8");
@@ -616,7 +616,7 @@
                                 },
                                 {
                                     "Priority": "low",
-                                    "Procedure": "bmc_code",
+                                    "Procedure": "BMC0001",
                                     "CalloutType": "config_procedure"
                                 }
                             ]
@@ -671,7 +671,7 @@
             EXPECT_EQ(callouts[1].symbolicFRUTrusted, "");
             EXPECT_EQ(callouts[2].priority, "low");
             EXPECT_EQ(callouts[2].locCode, "");
-            EXPECT_EQ(callouts[2].procedure, "bmc_code");
+            EXPECT_EQ(callouts[2].procedure, "BMC0001");
             EXPECT_EQ(callouts[2].symbolicFRU, "");
             EXPECT_EQ(callouts[2].symbolicFRUTrusted, "");
 

test/openpower-pels/src_test.cpp

diff --git a/test/openpower-pels/src_test.cpp b/test/openpower-pels/src_test.cpp
index d5d3b16..4a85bee 100644
--- a/test/openpower-pels/src_test.cpp
+++ b/test/openpower-pels/src_test.cpp
@@ -478,7 +478,7 @@
                 },
                 {
                     "Priority": "medium",
-                    "Procedure": "bmc_code"
+                    "Procedure": "BMC0001"
                 }
             ]
         },