commit 34c0c25840db1f4cc4f57ba10e70c79b590ee8b5
author Patrick Williams <patrick@stwcx.xyz> Tue Nov 04 22:30:46 2025 -0500
committer Matt Spinler <spinler@us.ibm.com> Wed Nov 05 21:58:10 2025 +0000
tree 108edc808dd547c6b8e25d48e96a884544882b84
parent 9cdb955d67edd3b1c2d373ebe68df5f0b0cd74b6

remove is_method_error call

An `is_method_error` is not appropriate after an sdbus `call` since
`call` will always throw an exception.  Remove the pointless call
and instead catch the exception.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iac59331eb31ef7b4c31f21ce4463c6bc7cf83e56

util.cpp

diff --git a/util.cpp b/util.cpp
index 492e954..db104bf 100644
--- a/util.cpp
+++ b/util.cpp
@@ -106,8 +106,11 @@
             auto method = bus.new_method_call(SYSTEMD_BUSNAME, SYSTEMD_PATH,
                                               SYSTEMD_INTERFACE, "KillUnit");
             method.append(JOURNAL_UNIT, "main", signal);
-            bus.call(method);
-            if (method.is_method_error())
+            try
+            {
+                bus.call(method);
+            }
+            catch (sdbusplus::exception_t&)
             {
                 lg2::error("Failed to kill journal service");
                 break;