tree 06dddb5d8a5d9d039c652be60ee9257a1a9a5204
parent 511a4752d23e00e6ad9f6b8d3f4be3964eeec220
author Patrick Williams <patrick@stwcx.xyz> 1630187160 -0500
committer Patrick Williams <patrick@stwcx.xyz> 1630360489 +0000

lg2: conversion: reduce std::forward clutter

It was observed in another repository that if the same std::string
was passed twice into lg2 function that clang-tidy would complain
about a potential use-after-realloc due to the 'string.data()' call
for the first instance followed by a 'std::forward' on the second
instance.  I don't think there was actually any issue with that, but
we don't really leverage r-value references in this code because there
is never an opportunity to 'std::move' any contents.  Remove the
clutter of 'std::forward' everywhere and simply rely on l-value
references, which is all the code needs anyhow.  This also placated
clang-tidy's memory use checker.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I89582e2f868732e9a7a08a7a24f858b9130d56bc