PEL: Fix some cppcheck warnings
This is the first of two commits to fix most of the cppcheck warnings in
the PEL code. It doesn't fix all of them because some are false
positives and some are just suggestions.
It's broken up into two commits to make them smaller.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I75937797a6920611b136d600e9efd6c694e4209c
diff --git a/extensions/openpower-pels/data_interface.cpp b/extensions/openpower-pels/data_interface.cpp
index 4fa802f..1c33579 100644
--- a/extensions/openpower-pels/data_interface.cpp
+++ b/extensions/openpower-pels/data_interface.cpp
@@ -723,7 +723,7 @@
break;
}
}
- itDumpStatus++;
+ ++itDumpStatus;
}
itDumpStatus = result.begin();
}
@@ -814,17 +814,18 @@
// If the entry isn't resolved
if (!status)
{
- auto service = getService(path, interface::association);
- if (!service.empty())
+ auto assocService =
+ getService(path, interface::association);
+ if (!assocService.empty())
{
- DBusValue value;
+ DBusValue endpoints;
// Read Endpoints property
- getProperty(service, path, interface::association,
- "endpoints", value);
+ getProperty(assocService, path, interface::association,
+ "endpoints", endpoints);
auto logPath =
- std::get<std::vector<std::string>>(value);
+ std::get<std::vector<std::string>>(endpoints);
if (!logPath.empty())
{
// Get OpenBMC event log Id