PEL: Fix some cppcheck warnings
This is the first of two commits to fix most of the cppcheck warnings in
the PEL code. It doesn't fix all of them because some are false
positives and some are just suggestions.
It's broken up into two commits to make them smaller.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I75937797a6920611b136d600e9efd6c694e4209c
diff --git a/extensions/openpower-pels/extended_user_data.hpp b/extensions/openpower-pels/extended_user_data.hpp
index be3db5b..07f9969 100644
--- a/extensions/openpower-pels/extended_user_data.hpp
+++ b/extensions/openpower-pels/extended_user_data.hpp
@@ -105,10 +105,10 @@
void updateDataSection(const uint8_t subType, const uint16_t componentId,
const std::vector<uint8_t>& newData)
{
- auto origDataSize = 0;
-
if (newData.size() >= 4)
{
+ size_t origDataSize{};
+
// Update component Id & subtype in section header of ED
_header.componentID = static_cast<uint16_t>(componentId);
_header.subType = static_cast<uint8_t>(subType);