PEL: Fix some cppcheck warnings
This is the first of two commits to fix most of the cppcheck warnings in
the PEL code. It doesn't fix all of them because some are false
positives and some are just suggestions.
It's broken up into two commits to make them smaller.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I75937797a6920611b136d600e9efd6c694e4209c
diff --git a/extensions/openpower-pels/manager.cpp b/extensions/openpower-pels/manager.cpp
index 152e4fb..e0186bc 100644
--- a/extensions/openpower-pels/manager.cpp
+++ b/extensions/openpower-pels/manager.cpp
@@ -387,14 +387,14 @@
auto src = pel->primarySRC();
if (src)
{
- auto msg =
+ auto m =
fmt::format("Created PEL {:#x} (BMC ID {}) with SRC {}", pel->id(),
pel->obmcLogID(), (*src)->asciiString());
- while (msg.back() == ' ')
+ while (m.back() == ' ')
{
- msg.pop_back();
+ m.pop_back();
}
- log<level::INFO>(msg.c_str());
+ log<level::INFO>(m.c_str());
}
// Check for severity 0x51 and update boot progress SRC
@@ -648,8 +648,6 @@
std::string Manager::getPELJSON(uint32_t obmcLogID)
{
- Repository::LogID id{Repository::LogID::Obmc(obmcLogID)};
-
// Throws InvalidArgument if not found
auto pelID = getPELIdFromBMCLogId(obmcLogID);