PEL: Fix some cppcheck warnings
This is the first of two commits to fix most of the cppcheck warnings in
the PEL code. It doesn't fix all of them because some are false
positives and some are just suggestions.
It's broken up into two commits to make them smaller.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I75937797a6920611b136d600e9efd6c694e4209c
diff --git a/extensions/openpower-pels/pel.cpp b/extensions/openpower-pels/pel.cpp
index a84b7f8..3de2fa3 100644
--- a/extensions/openpower-pels/pel.cpp
+++ b/extensions/openpower-pels/pel.cpp
@@ -47,7 +47,6 @@
{
namespace pels
{
-namespace message = openpower::pels::message;
namespace pv = openpower::pels::pel_values;
using namespace phosphor::logging;
@@ -185,9 +184,9 @@
addUserDataSection(std::move(ud));
// Also put in the journal for debug
- for (const auto& [name, data] : debugData)
+ for (const auto& [name, msgs] : debugData)
{
- for (const auto& message : data)
+ for (const auto& message : msgs)
{
std::string entry = name + ": " + message;
log<level::INFO>(entry.c_str());