PEL: Fix some cppcheck warnings
This is the first of two commits to fix most of the cppcheck warnings in
the PEL code. It doesn't fix all of them because some are false
positives and some are just suggestions.
It's broken up into two commits to make them smaller.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I75937797a6920611b136d600e9efd6c694e4209c
diff --git a/extensions/openpower-pels/repository.cpp b/extensions/openpower-pels/repository.cpp
index b418c39..ee0d232 100644
--- a/extensions/openpower-pels/repository.cpp
+++ b/extensions/openpower-pels/repository.cpp
@@ -668,16 +668,16 @@
if (!obmcLogIDs.empty())
{
- std::string msg = "Number of PELs removed to save space: " +
- std::to_string(obmcLogIDs.size());
- log<level::INFO>(msg.c_str());
+ std::string m = "Number of PELs removed to save space: " +
+ std::to_string(obmcLogIDs.size());
+ log<level::INFO>(m.c_str());
}
return obmcLogIDs;
}
-void Repository::removePELs(IsOverLimitFunc& isOverLimit,
- IsPELTypeFunc& isPELType,
+void Repository::removePELs(const IsOverLimitFunc& isOverLimit,
+ const IsPELTypeFunc& isPELType,
const std::vector<uint32_t>& idsWithHwIsoEntry,
std::vector<uint32_t>& removedBMCLogIDs)
{