PEL: Remove 'no_vpd_for_fru' maintenance procedure
This procedure was being used in a callout when the location code could
not be found on an inventory item. The code was changed to just not add
a callout in this case.
This was done for the following reasons:
1) There's no expected reason that the inventory would be missing a
location code for a valid inventory path.
2) There wasn't a way to give a hint to the end user about what the
callout should be in that case. Usually maintenance procedures should
have steps one can take to still do the appropriate replacement.
3) Because of 1), this case indicates a bad inventory path passed in by
the caller. Theoretically there is a way to have a 'bmc_code'
callout, but that wouldn't be appropriate to add in this log since
the intent of this one is for another problem.
3a) There is no way to create a new error log from inside a PEL section,
and I don't think this one case warrants coming up with a way to do
so.
4) The inventory path in question is still being added into a UserData
section so that development can debug it.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I0757080f04942807cc34029d8667387db6b959fe
diff --git a/test/openpower-pels/src_test.cpp b/test/openpower-pels/src_test.cpp
index 3149378..713eed5 100644
--- a/test/openpower-pels/src_test.cpp
+++ b/test/openpower-pels/src_test.cpp
@@ -393,7 +393,7 @@
}
// Test that when the location code can't be obtained that
-// a procedure callout is used.
+// no callout is added.
TEST_F(SRCTest, InventoryCalloutNoLocCodeTest)
{
message::Entry entry;
@@ -420,20 +420,7 @@
SRC src{entry, ad, dataIface};
EXPECT_TRUE(src.valid());
- ASSERT_TRUE(src.callouts());
-
- EXPECT_EQ(src.callouts()->callouts().size(), 1);
-
- auto& callout = src.callouts()->callouts().front();
- EXPECT_EQ(callout->locationCodeSize(), 0);
- EXPECT_EQ(callout->priority(), 'H');
-
- auto& fru = callout->fruIdentity();
-
- EXPECT_EQ(fru->getMaintProc().value(), "BMCSP01");
- EXPECT_FALSE(fru->getPN());
- EXPECT_FALSE(fru->getSN());
- EXPECT_FALSE(fru->getCCIN());
+ ASSERT_FALSE(src.callouts());
// flatten and unflatten
std::vector<uint8_t> data;
@@ -443,8 +430,7 @@
stream.offset(0);
SRC newSRC{stream};
EXPECT_TRUE(newSRC.valid());
- ASSERT_TRUE(src.callouts());
- EXPECT_EQ(src.callouts()->callouts().size(), 1);
+ ASSERT_FALSE(src.callouts());
}
// Test that when the VPD can't be obtained that
@@ -519,7 +505,7 @@
},
{
"Priority": "medium",
- "Procedure": "no_vpd_for_fru"
+ "Procedure": "bmc_code"
}
]
},