commit 4b59f7ad8462bea683ac93048395e5e9f41d40e5
author Matt Spinler <spinler@us.ibm.com> Tue Oct 08 13:55:17 2019 -0500
committer Matt Spinler <spinler@us.ibm.com> Tue Oct 22 14:09:56 2019 +0000
tree 9c0af2749a534a7cbdab8cb6ceeea3e4e55405bc
parent a906c940ef1ebb78d8ae876ec90777aa447a3a76

PEL: Add string accessors to MTMS class

This class is used by a few other classes, so make it easier to get
data out of it.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I2feb4b83a09e6cb6056c9f1a903ca55e8cacf2ae

test/openpower-pels/mtms_test.cpp

diff --git a/test/openpower-pels/mtms_test.cpp b/test/openpower-pels/mtms_test.cpp
index 999100f..2290374 100644
--- a/test/openpower-pels/mtms_test.cpp
+++ b/test/openpower-pels/mtms_test.cpp
@@ -18,11 +18,13 @@
         MTMS mtms{tm, sn};
 
         std::array<uint8_t, 8> t{'T', 'T', 'T', 'T', '-', 'M', 'M', 'M'};
-        EXPECT_EQ(t, mtms.machineTypeAndModel());
+        EXPECT_EQ(t, mtms.machineTypeAndModelRaw());
+        EXPECT_EQ("TTTT-MMM", mtms.machineTypeAndModel());
 
         std::array<uint8_t, 12> s{'1', '2', '3', '4', '5', '6',
                                   '7', '8', '9', 'A', 'B', 'C'};
-        EXPECT_EQ(s, mtms.machineSerialNumber());
+        EXPECT_EQ(s, mtms.machineSerialNumberRaw());
+        EXPECT_EQ("123456789ABC", mtms.machineSerialNumber());
     }
 
     {
@@ -33,11 +35,11 @@
         MTMS mtms{tm, sn};
 
         std::array<uint8_t, 8> t{'T', 'T', 'T', 'T', '-', 'M', 'M', 'M'};
-        EXPECT_EQ(t, mtms.machineTypeAndModel());
+        EXPECT_EQ(t, mtms.machineTypeAndModelRaw());
 
         std::array<uint8_t, 12> s{'1', '2', '3', '4', '5', '6',
                                   '7', '8', '9', 'A', 'B', 'C'};
-        EXPECT_EQ(s, mtms.machineSerialNumber());
+        EXPECT_EQ(s, mtms.machineSerialNumberRaw());
     }
 
     {
@@ -48,10 +50,12 @@
         MTMS mtms{tm, sn};
 
         std::array<uint8_t, 8> t{'T', 'T', 'T', 'T', 0, 0, 0, 0};
-        EXPECT_EQ(t, mtms.machineTypeAndModel());
+        EXPECT_EQ(t, mtms.machineTypeAndModelRaw());
+        EXPECT_EQ("TTTT", mtms.machineTypeAndModel());
 
         std::array<uint8_t, 12> s{'1', '2', '3', '4', 0, 0, 0, 0, 0, 0, 0, 0};
-        EXPECT_EQ(s, mtms.machineSerialNumber());
+        EXPECT_EQ(s, mtms.machineSerialNumberRaw());
+        EXPECT_EQ("1234", mtms.machineSerialNumber());
     }
 
     {
@@ -63,12 +67,9 @@
 
         MTMS mtms{stream};
 
-        std::array<uint8_t, 8> t{'T', 'T', 'T', 'T', '-', 'M', 'M', 'M'};
-        EXPECT_EQ(t, mtms.machineTypeAndModel());
+        EXPECT_EQ("TTTT-MMM", mtms.machineTypeAndModel());
 
-        std::array<uint8_t, 12> s{'1', '2', '3', '4', '5', '6',
-                                  '7', '8', '9', 'A', 'B', 'C'};
-        EXPECT_EQ(s, mtms.machineSerialNumber());
+        EXPECT_EQ("123456789ABC", mtms.machineSerialNumber());
     }
 }
 
@@ -100,10 +101,7 @@
     MTMS mtms;
     stream >> mtms;
 
-    std::array<uint8_t, 8> t{'T', 'T', 'T', 'T', '-', 'M', 'M', 'M'};
-    EXPECT_EQ(t, mtms.machineTypeAndModel());
+    EXPECT_EQ("TTTT-MMM", mtms.machineTypeAndModel());
 
-    std::array<uint8_t, 12> s{'1', '2', '3', '4', '5', '6',
-                              '7', '8', '9', 'A', 'B', 'C'};
-    EXPECT_EQ(s, mtms.machineSerialNumber());
+    EXPECT_EQ("123456789ABC", mtms.machineSerialNumber());
 }