commit 511a4752d23e00e6ad9f6b8d3f4be3964eeec220
author Patrick Williams <patrick@stwcx.xyz> Sat Aug 28 15:23:26 2021 -0500
committer Patrick Williams <patrick@stwcx.xyz> Mon Aug 30 21:54:49 2021 +0000
tree c6b9325dcea06ef44ed2a341da229375476a32a1
parent e917611a0107b36f8afde08e7160c6e188ab8e81

rsyslog-config: warning due to bad std::move

Clang reports the following warning:
```
../phosphor-rsyslog-config/server-conf.cpp:124:18: warning:
moving a temporary object prevents copy elision [-Wpessimizing-move]
        result = std::move(NetworkClient::address(value));
                         ^
```

Calling std::move on a temporary is useless and does, as clang
rightly warns, actually make things worse by preventing copy-elision.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3246810dd786a3fb0dceeed09fcf22e4e30b4df8

phosphor-rsyslog-config/server-conf.cpp

diff --git a/phosphor-rsyslog-config/server-conf.cpp b/phosphor-rsyslog-config/server-conf.cpp
index 9ed18e8..fb5d086 100644
--- a/phosphor-rsyslog-config/server-conf.cpp
+++ b/phosphor-rsyslog-config/server-conf.cpp
@@ -121,7 +121,7 @@
         }
 
         writeConfig(value, port(), configFilePath.c_str());
-        result = std::move(NetworkClient::address(value));
+        result = NetworkClient::address(value);
     }
     catch (const InvalidArgument& e)
     {