commit 527ff346907354a2ce03678c1c2a523108e8b4bc
author Matt Spinler <spinler@us.ibm.com> Thu Jun 29 12:52:34 2023 -0500
committer Matt Spinler <spinler@us.ibm.com> Tue Jul 11 21:45:10 2023 +0000
tree 9ad92289e64d22f89ef71d7260f087c9867fabef
parent 1b41886d1ba223437ed35f4e04f3cad2e77c94ef

PEL: Handle failing to start a PLDM cmd better

A recent PLDM bug caused the registerReceiveCallback() function,  which
is used to setup listening for the PLDM response from the host when
telling them about a new PEL, to throw an exception.

When this happened, the code got stuck in the 'in progress' state, so it
would never try again when the next PEL came in.

Fix that by having startCommand() throw an exception instead of calling
the failure response function callback.  With this change, the code will
continue on to call the cleanupCmd() function so everything is ready
when the next PEL comes in.

Tested:
With the bad PLDM code, after the first PEL ran out of retry attempts,
created another PEL and saw the code attempt again to call PLDM. Also,
wrote a new unit test case for it.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I38034440435d6a86e8dd880eef09499f19dd6e9c

extensions/openpower-pels/pldm_interface.cpp

diff --git a/extensions/openpower-pels/pldm_interface.cpp b/extensions/openpower-pels/pldm_interface.cpp
index 502cc7d..3326d82 100644
--- a/extensions/openpower-pels/pldm_interface.cpp
+++ b/extensions/openpower-pels/pldm_interface.cpp
@@ -97,7 +97,7 @@
         auto e = errno;
         lg2::error("pldm_open failed.  errno = {ERRNO}, rc = {RC}", "ERRNO", e,
                    "RC", _fd);
-        throw std::exception{};
+        throw std::runtime_error{"pldm_open failed"};
     }
 }
 
@@ -140,7 +140,14 @@
     }
     else
     {
-        startCommand();
+        try
+        {
+            startCommand();
+        }
+        catch (const std::exception& e)
+        {
+            callResponseFunc(ResponseStatus::failure);
+        }
     }
 }
 
@@ -167,9 +174,11 @@
     }
     catch (const std::exception& e)
     {
+        lg2::error("startCommand exception: {ERROR}", "ERROR", e);
+
         cleanupCmd();
 
-        callResponseFunc(ResponseStatus::failure);
+        throw;
     }
 }
 
@@ -184,6 +193,7 @@
         lg2::error(
             "Error calling sd_bus_call_method_async, rc = {RC}, msg = {MSG}",
             "RC", rc, "MSG", strerror(-rc));
+        throw std::runtime_error{"sd_bus_call_method_async failed"};
     }
 }
 
@@ -237,7 +247,7 @@
     if (rc != PLDM_SUCCESS)
     {
         lg2::error("encode_new_file_req failed, rc = {RC}", "RC", rc);
-        throw std::exception{};
+        throw std::runtime_error{"encode_new_file_req failed"};
     }
 
     rc = pldm_send(_eid, _fd, requestMsg.data(), requestMsg.size());
@@ -246,8 +256,7 @@
         auto e = errno;
         lg2::error("pldm_send failed, rc = {RC}, errno = {ERRNO}", "RC", rc,
                    "ERRNO", e);
-
-        throw std::exception{};
+        throw std::runtime_error{"pldm_send failed"};
     }
 }