PEL: Trace less when watching Present changes
The fans and power supplies in IO expansion drawers are also in the
inventory, hosted by PLDM, and have their Present property set to true
at least once every boot after the hypervisor starts and tells PLDM
they are present. This causes multiple traces every boot from the PEL
code watching for fan and power supply hot plugs. Also, one of the
times the items become present, the call to get its location code from
PLDM fails which causes another trace.
Since the PEL code doesn't care about fans and PSs in IO drawers, just
change these traces to debug ones so that no traces show up on normal
boots. There will still be a trace if the code does end up clearing the
deconfig flag from a PEL with a plugged local fan/PS as a callout.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I18cf95e6adfc6aa5700fe33a74c18014b36d0b9d
diff --git a/extensions/openpower-pels/data_interface.cpp b/extensions/openpower-pels/data_interface.cpp
index 8da6d88..a74a840 100644
--- a/extensions/openpower-pels/data_interface.cpp
+++ b/extensions/openpower-pels/data_interface.cpp
@@ -981,29 +981,31 @@
void DataInterface::notifyPresenceSubsribers(const std::string& path,
const DBusPropertyMap& properties)
{
+ auto prop = properties.find("Present");
+ if ((prop == properties.end()) || (!std::get<bool>(prop->second)))
+ {
+ return;
+ }
+
+ std::string locCode;
+
try
{
- auto prop = properties.find("Present");
- if (prop != properties.end())
- {
- if (std::get<bool>(prop->second))
- {
- auto locCode = getLocationCode(path);
- log<level::INFO>(
- fmt::format("Detected FRU {} ({}) present ", path, locCode)
- .c_str());
- // Tell the subscribers.
- setFruPresent(locCode);
- }
- }
+ locCode = getLocationCode(path);
}
- catch (const std::exception& e)
+ catch (const sdbusplus::exception_t& e)
{
- log<level::ERR>(
- fmt::format("Failed while processing presence for {}: {}", path,
- e.what())
- .c_str());
+ log<level::DEBUG>(fmt::format("Could not get location code for {}: {}",
+ path, e.what())
+ .c_str());
+ return;
}
+
+ log<level::DEBUG>(
+ fmt::format("Detected FRU {} ({}) present ", path, locCode).c_str());
+
+ // Tell the subscribers.
+ setFruPresent(locCode);
}
} // namespace pels
} // namespace openpower