commit 6ef6b25e44e07e1af74f2578d30331922c7879ac
author Patrick Williams <patrick@stwcx.xyz> Wed Mar 30 14:28:27 2022 -0500
committer Patrick Williams <patrick@stwcx.xyz> Sat Apr 02 11:47:06 2022 +0000
tree d620956d169e98d293e18da065b35b463a9e45fc
parent aa85a0729ce26eb3a9b759fb87fb96d5caa3b7a3

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications.  Map all `true` occurrences to
`action::defer_emit`.

Change-Id: I21f8e8d8e988ee29933b544fd4ffd8bf0fe3963c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

elog_entry.hpp

diff --git a/elog_entry.hpp b/elog_entry.hpp
index 38c4e84..609f905 100644
--- a/elog_entry.hpp
+++ b/elog_entry.hpp
@@ -67,7 +67,7 @@
           std::string&& msgErr, std::vector<std::string>&& additionalDataErr,
           AssociationList&& objects, const std::string& fwVersion,
           const std::string& filePath, internal::Manager& parent) :
-        EntryIfaces(bus, objectPath.c_str(), true),
+        EntryIfaces(bus, objectPath.c_str(), EntryIfaces::action::defer_emit),
         parent(parent)
     {
         id(idErr, true);
@@ -100,7 +100,7 @@
      */
     Entry(sdbusplus::bus::bus& bus, const std::string& path, uint32_t entryId,
           internal::Manager& parent) :
-        EntryIfaces(bus, path.c_str(), true),
+        EntryIfaces(bus, path.c_str(), EntryIfaces::action::defer_emit),
         parent(parent)
     {
         id(entryId, true);

log_manager.hpp

diff --git a/log_manager.hpp b/log_manager.hpp
index 6dbd29c..4863ad5 100644
--- a/log_manager.hpp
+++ b/log_manager.hpp
@@ -363,8 +363,10 @@
      */
     Manager(sdbusplus::bus::bus& bus, const std::string& path,
             internal::Manager& manager) :
-        details::ServerObject<DeleteAllIface, CreateIface>(bus, path.c_str(),
-                                                           true),
+        details::ServerObject<DeleteAllIface, CreateIface>(
+            bus, path.c_str(),
+            details::ServerObject<DeleteAllIface,
+                                  CreateIface>::action::defer_emit),
         manager(manager){};
 
     /** @brief Delete all d-bus objects.

phosphor-rsyslog-config/server-conf.hpp

diff --git a/phosphor-rsyslog-config/server-conf.hpp b/phosphor-rsyslog-config/server-conf.hpp
index 979f845..5b3c5a1 100644
--- a/phosphor-rsyslog-config/server-conf.hpp
+++ b/phosphor-rsyslog-config/server-conf.hpp
@@ -40,7 +40,7 @@
      */
     Server(sdbusplus::bus::bus& bus, const std::string& path,
            const char* filePath) :
-        Iface(bus, path.c_str(), true),
+        Iface(bus, path.c_str(), Iface::action::defer_emit),
         configFilePath(filePath),
         hostnameChange(
             bus,