PEL: Clean up PEL Entry D-bus signals
Don't emit an InterfacesAdded signal when restoring the
org.open_power.Logging.PEL.Entry interface on D-Bus, since this happens
before the bus name is claimed.
Also, don't emit PropertiesChanged signals when the PEL code updates the
Resolution, EventID, and ServiceProviderNotify properties with their
final values on the xyz.openbmc_project.Logging.Entry interface.
Definitely the PC signals aren't necessary during the restore phase, and
while technically it'd be valid to send them after the IA signal has
already been emitted for the Logging.Entry interface, nobody is
listening for them anyway and doing it this way makes it so only
InterfacesAdded signals are emitted when event logs are created.
Change-Id: Ia30163fb58e78d3746015903acc7597b2a097aa4
diff --git a/extensions/openpower-pels/manager.cpp b/extensions/openpower-pels/manager.cpp
index f3487b3..4c90d1e 100644
--- a/extensions/openpower-pels/manager.cpp
+++ b/extensions/openpower-pels/manager.cpp
@@ -769,7 +769,7 @@
auto entryN = _logManager.entries.find(pel->obmcLogID());
if (entryN != _logManager.entries.end())
{
- entryN->second->resolution(callouts);
+ entryN->second->resolution(callouts, true);
}
}
@@ -782,7 +782,7 @@
auto entry = _logManager.entries.find(obmcLogID);
if (entry != _logManager.entries.end())
{
- entry->second->path(attr.path);
+ entry->second->path(attr.path, true);
}
}
}
@@ -797,12 +797,12 @@
if (entry != _logManager.entries.end())
{
entry->second->serviceProviderNotify(
- attr.actionFlags.test(callHomeFlagBit));
+ attr.actionFlags.test(callHomeFlagBit), true);
}
}
}
-void Manager::createPELEntry(uint32_t obmcLogID)
+void Manager::createPELEntry(uint32_t obmcLogID, bool skipIaSignal)
{
std::map<std::string, PropertiesVariant> varData;
Repository::LogID id{Repository::LogID::Obmc(obmcLogID)};
@@ -836,7 +836,10 @@
// Create Interface for PELEntry and set properties
auto pelEntry = std::make_unique<PELEntry>(_logManager.getBus(), path,
varData, obmcLogID, &_repo);
- pelEntry->emit_added();
+ if (!skipIaSignal)
+ {
+ pelEntry->emit_added();
+ }
_pelEntries.emplace(std::move(path), std::move(pelEntry));
}
}