commit 79f206b8abbbbfdec0df0f9790e6c7697aafa9f8
author Patrick Williams <patrick@stwcx.xyz> Thu Oct 03 09:53:18 2024 -0400
committer Patrick Williams <patrick@stwcx.xyz> Thu Oct 03 09:53:30 2024 -0400
tree 19f9ae608447e5b8c87bd2c3552b91d4ba150168
parent 730c40faeee08a09aa35b1fec30fa7c5f335a440

log-manager: fix arg bounds

An incorrect argument count check results in `argv[1]` being accessed
even when it is not provided.  This causes a SEGV on launch of the
daemon in normal cases (on a system) when the temporary path location
is not provided.

Fixes: fa2d962b5da807ac17bb7a355709ff05dd10d041
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibe7254533cb6002d73c5a1ada8bb1f35e9c9df53

log_manager_main.cpp

diff --git a/log_manager_main.cpp b/log_manager_main.cpp
index fda9119..173b6e5 100644
--- a/log_manager_main.cpp
+++ b/log_manager_main.cpp
@@ -17,7 +17,7 @@
 {
     PHOSPHOR_LOG2_USING_WITH_FLAGS;
 
-    if (argc >= 1)
+    if (argc >= 2)
     {
         PERSIST_PATH_ROOT = strdup(argv[1]);
         info("Using temporary {PATH} for logs", "PATH", PERSIST_PATH_ROOT);