PEL: Put validation fail details into journal msg
In the PEL section classes, move some journal fields from the journal
metadata section into the journal message itself, to make debug slightly
easier.
Specifically, this is just for when unflattening or validating the
sections fail.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I6d5661015b5ce5c07ed2fd6eb7ce864d0c620092
diff --git a/extensions/openpower-pels/failing_mtms.cpp b/extensions/openpower-pels/failing_mtms.cpp
index 0e82bd0..d4db58f 100644
--- a/extensions/openpower-pels/failing_mtms.cpp
+++ b/extensions/openpower-pels/failing_mtms.cpp
@@ -19,6 +19,8 @@
#include "pel_types.hpp"
#include "pel_values.hpp"
+#include <fmt/format.h>
+
#include <phosphor-logging/log.hpp>
namespace openpower
@@ -51,8 +53,9 @@
}
catch (const std::exception& e)
{
- log<level::ERR>("Cannot unflatten failing MTM section",
- entry("ERROR=%s", e.what()));
+ log<level::ERR>(
+ fmt::format("Cannot unflatten failing MTM section: {}", e.what())
+ .c_str());
_valid = false;
}
}
@@ -63,15 +66,17 @@
if (header().id != static_cast<uint16_t>(SectionID::failingMTMS))
{
- log<level::ERR>("Invalid failing MTMS section ID",
- entry("ID=0x%X", header().id));
+ log<level::ERR>(
+ fmt::format("Invalid failing MTMS section ID: {0:#x}", header().id)
+ .c_str());
failed = true;
}
if (header().version != failingMTMSVersion)
{
- log<level::ERR>("Invalid failing MTMS version",
- entry("VERSION=0x%X", header().version));
+ log<level::ERR>(fmt::format("Invalid failing MTMS version: {0:#x}",
+ header().version)
+ .c_str());
failed = true;
}