PEL: Change method of asserting a fault LED
There was a recent change in direction on how PELs should request that
fault LEDs be turned on. Previously, the code would talk to the LED
group objects directly. The new direction is to set the Functional
property on the OperationalStatus interface on the inventory objects in
question to false, and the LED manager code will watch that to know when
to turn on the LEDs.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ieebb09ba002843cf863359a09aba26540356aa91
diff --git a/extensions/openpower-pels/data_interface.hpp b/extensions/openpower-pels/data_interface.hpp
index 9a48721..385b07a 100644
--- a/extensions/openpower-pels/data_interface.hpp
+++ b/extensions/openpower-pels/data_interface.hpp
@@ -279,17 +279,6 @@
bool expanded) const = 0;
/**
- * @brief Returns the fault LED group D-Bus path for the inventory
- * D-Bus path passed in.
- *
- * @param[in] inventoryPath - The inventory D-Bus path
- *
- * @return std::string - The fault LED group D-Bus path
- */
- virtual std::string
- getFaultLEDGroup(const std::string& inventoryPath) const = 0;
-
- /**
* @brief Sets the Asserted property on the LED group passed in.
*
* @param[in] ledGroup - The LED group D-Bus path
@@ -298,6 +287,16 @@
virtual void assertLEDGroup(const std::string& ledGroup,
bool value) const = 0;
+ /**
+ * @brief Sets the Functional property on the OperationalStatus
+ * interface on a D-Bus object.
+ *
+ * @param[in] objectPath - The D-Bus object path
+ * @param[in] functional - The value
+ */
+ virtual void setFunctional(const std::string& objectPath,
+ bool functional) const = 0;
+
protected:
/**
* @brief Sets the host on/off state and runs any
@@ -528,17 +527,6 @@
bool expanded) const override;
/**
- * @brief Returns the fault LED group D-Bus path for the inventory
- * D-Bus path passed in.
- *
- * @param[in] inventoryPath - The inventory D-Bus path
- *
- * @return std::string - The fault LED group D-Bus path
- */
- std::string
- getFaultLEDGroup(const std::string& inventoryPath) const override;
-
- /**
* @brief Sets the Asserted property on the LED group passed in.
*
* @param[in] ledGroup - The LED group D-Bus path
@@ -546,6 +534,16 @@
*/
void assertLEDGroup(const std::string& ledGroup, bool value) const override;
+ /**
+ * @brief Sets the Functional property on the OperationalStatus
+ * interface on a D-Bus object.
+ *
+ * @param[in] objectPath - The D-Bus object path
+ * @param[in] functional - The value
+ */
+ void setFunctional(const std::string& objectPath,
+ bool functional) const override;
+
private:
/**
* @brief Reads the BMC firmware version string and puts it into