PEL: Get rid of the enum for a maint procedure
It simplifies the code to just use the string name of the procedure as defined
by the message registry schema, and make it be less maintenance to add
new procedures in the future, especially if they come from the registry
so the enum isn't even needed.
This will also make it the same as upcoming support for symbolic FRU
callouts, which will always just come from the registry or an external
user so would not need an enum.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ia8550235678ba1fc717a6b0875e2d7ff3888bfec
diff --git a/extensions/openpower-pels/pel_values.cpp b/extensions/openpower-pels/pel_values.cpp
index 9fb6f05..07a0671 100644
--- a/extensions/openpower-pels/pel_values.cpp
+++ b/extensions/openpower-pels/pel_values.cpp
@@ -212,10 +212,11 @@
{0x4C, "low", "Lowest priority replacement"}};
/**
- * @brief The possible maintenance procedures.
+ * @brief Map of the registry names for the maintenance procedures
+ * to their actual names.
*/
-const MaintenanceProcedureValues maintenanceProcedures = {
- {MaintProcedure::noVPDforFRU, "no_vpd_for_fru", "BMCSP01"}};
+const std::map<std::string, std::string> maintenanceProcedures = {
+ {"no_vpd_for_fru", "BMCSP01"}};
PELValues::const_iterator findByValue(uint32_t value, const PELValues& fields)
{
@@ -329,20 +330,6 @@
return foundValues;
}
-MaintenanceProcedureValues::const_iterator
- getMaintProcedure(MaintProcedure procedure)
-{
- auto proc =
- std::find_if(maintenanceProcedures.begin(), maintenanceProcedures.end(),
- [procedure](const auto& entry) {
- return std::get<mpEnumPos>(entry) == procedure;
- });
-
- assert(proc != maintenanceProcedures.end());
-
- return proc;
-}
-
} // namespace pel_values
} // namespace pels
} // namespace openpower