commit b2e541ee2503da7c03f6fdadefce9cdba396ecea
author Vijay Lobo <vijaylobo@gmail.com> Tue Aug 31 23:12:47 2021 -0500
committer Matt Spinler <spinler@us.ibm.com> Wed Sep 08 15:15:21 2021 +0000
tree b90655934d7369108066b0602d6cf33d35bbc45c
parent 9d43a7277ab2ff069c10f87216c067ae1dbca5ee

PEL.Entry update hidden property setting

The condition to set hidden flag depends on the severity type and the
action flag setting. This change is to make sure that the hidden
property is set using various conditions and not just hidden action flag.

Tested:
using busctl injected different types of errors and made sure that the
hidden property is set accordingly.

Signed-off-by: Vijay Lobo <vijaylobo@gmail.com>
Change-Id: I91ad232e50b0201f5d58e0f145a013b8994c3a9b

extensions/openpower-pels/manager.cpp

diff --git a/extensions/openpower-pels/manager.cpp b/extensions/openpower-pels/manager.cpp
index df8e50c..facaabb 100644
--- a/extensions/openpower-pels/manager.cpp
+++ b/extensions/openpower-pels/manager.cpp
@@ -804,8 +804,19 @@
     {
         namespace pv = openpower::pels::pel_values;
         auto& attr = attributes.value().get();
-        varData.emplace(std::string("Hidden"),
-                        attr.actionFlags.test(hiddenFlagBit));
+
+        // get the hidden flag values
+        auto sevType = static_cast<SeverityType>(attr.severity & 0xF0);
+        auto isHidden = true;
+        if (((sevType != SeverityType::nonError) &&
+             attr.actionFlags.test(reportFlagBit) &&
+             !attr.actionFlags.test(hiddenFlagBit)) ||
+            ((sevType == SeverityType::nonError) &&
+             attr.actionFlags.test(serviceActionFlagBit)))
+        {
+            isHidden = false;
+        }
+        varData.emplace(std::string("Hidden"), isHidden);
         varData.emplace(
             std::string("Subsystem"),
             pv::getValue(attr.subsystem, pel_values::subsystemValues));