Factor out log creation code common code.
In preparation for adding another function to create a log entry, factor
out some common code into a new function that will be able to be called
in both spots.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I8881f4ec0d36a2b2e2b1897b63d524022a328286
diff --git a/log_manager.cpp b/log_manager.cpp
index 0f4e57c..2920546 100644
--- a/log_manager.cpp
+++ b/log_manager.cpp
@@ -79,24 +79,6 @@
void Manager::_commit(uint64_t transactionId, std::string&& errMsg,
Entry::Level errLvl)
{
- if (!Extensions::disableDefaultLogCaps())
- {
- if (errLvl < Entry::sevLowerLimit)
- {
- if (realErrors.size() >= ERROR_CAP)
- {
- erase(realErrors.front());
- }
- }
- else
- {
- if (infoErrors.size() >= ERROR_INFO_CAP)
- {
- erase(infoErrors.front());
- }
- }
- }
-
constexpr const auto transactionIdVar = "TRANSACTION_ID";
// Length of 'TRANSACTION_ID' string.
constexpr const auto transactionIdVarSize = std::strlen(transactionIdVar);
@@ -199,7 +181,30 @@
sd_journal_close(j);
- // Create error Entry dbus object
+ createEntry(errMsg, errLvl, additionalData);
+}
+
+void Manager::createEntry(std::string errMsg, Entry::Level errLvl,
+ std::vector<std::string> additionalData)
+{
+ if (!Extensions::disableDefaultLogCaps())
+ {
+ if (errLvl < Entry::sevLowerLimit)
+ {
+ if (realErrors.size() >= ERROR_CAP)
+ {
+ erase(realErrors.front());
+ }
+ }
+ else
+ {
+ if (infoErrors.size() >= ERROR_INFO_CAP)
+ {
+ erase(infoErrors.front());
+ }
+ }
+ }
+
entryId++;
if (errLvl >= Entry::sevLowerLimit)
{