commit bf27da63180a019a59db528a94100be955872681
author Matt Spinler <spinler@us.ibm.com> Fri May 09 14:18:04 2025 -0500
committer Matt Spinler <spinler@us.ibm.com> Fri May 30 20:02:49 2025 +0000
tree fcd8b23c39fb8671fd1a8d3b37d0307676feb5c4
parent 8a09b982ddeb0c1e13190d9cd196e06a778d6140

PEL: Remove Section::validate() virtual func

There is no need for the validate() function that every PEL section uses
to be virtual, because it is always called directly by the class it's
defined in.

Also, cppcheck was complaining that constructors, where validate() is
called, can't call virtual functions anyway.

Tested:
Unit tests pass

Change-Id: I7190a5299baa85f7956963e21189da0f4c62b68a
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

extensions/openpower-pels/src.hpp

diff --git a/extensions/openpower-pels/src.hpp b/extensions/openpower-pels/src.hpp
index 781274e..b849c1e 100644
--- a/extensions/openpower-pels/src.hpp
+++ b/extensions/openpower-pels/src.hpp
@@ -428,7 +428,7 @@
      *
      * Updates _valid (in Section) with the results.
      */
-    void validate() override;
+    void validate();
 
     /**
      * @brief Get error description from message registry