PEL: Fix the memory leak error when parsing multiple ffdc packets
"ffdcData" array pointer of sbeFfdcPacketType is deleted as part
of the struct destructor
As the ffdcPkt is declared in the outer scope, the memory allocated
gets released only once, and for multiple packets, there will be
memory leak
Change-Id: I2b224ea3db067d4086dbf3ab03ef65a21ae72b0e
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
diff --git a/extensions/openpower-pels/sbe_ffdc_handler.cpp b/extensions/openpower-pels/sbe_ffdc_handler.cpp
index d1a2469..67f515c 100644
--- a/extensions/openpower-pels/sbe_ffdc_handler.cpp
+++ b/extensions/openpower-pels/sbe_ffdc_handler.cpp
@@ -104,7 +104,6 @@
uint32_t ffdcBufOffset = 0;
uint32_t pktCount = 0;
- sbeFfdcPacketType ffdcPkt;
// get SBE FFDC data.
auto ffdcData = util::readFD(fd);
@@ -117,6 +116,8 @@
while ((ffdcBufOffset < ffdcData.size()) && (sbeMaxFfdcPackets != pktCount))
{
+ sbeFfdcPacketType ffdcPkt;
+
// Next un-extracted FFDC Packet
fapiFfdcBufType* ffdc =
reinterpret_cast<fapiFfdcBufType*>(ffdcData.data() + ffdcBufOffset);