PEL: Move down quiesce check
Move the check where the host quiesce target may get started based on
the PEL severity to the last thing that happens when either a PEL is
created by BMC code or received by the host. It just seems more
straight forward to not start systemd targets before even filling in all
of the PEL related D-Bus properties.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I689d9947ebeabfdd914b43d32b49c7f1b6cbcdd7
diff --git a/extensions/openpower-pels/manager.cpp b/extensions/openpower-pels/manager.cpp
index ee5919d..d44fe35 100644
--- a/extensions/openpower-pels/manager.cpp
+++ b/extensions/openpower-pels/manager.cpp
@@ -195,11 +195,12 @@
entry("PEL_ID=0x%X", pel->id()));
}
- // Check if firmware should quiesce system due to error
- checkPelAndQuiesce(pel);
updateEventId(pel);
updateResolution(*pel);
createPELEntry(obmcLogID);
+
+ // Check if firmware should quiesce system due to error
+ checkPelAndQuiesce(pel);
}
else
{
@@ -402,11 +403,12 @@
auto policy = service_indicators::getPolicy(*_dataIface);
policy->activate(*pel);
- // Check if firmware should quiesce system due to error
- checkPelAndQuiesce(pel);
updateEventId(pel);
updateResolution(*pel);
createPELEntry(obmcLogID);
+
+ // Check if firmware should quiesce system due to error
+ checkPelAndQuiesce(pel);
}
sdbusplus::message::unix_fd Manager::getPEL(uint32_t pelID)