Stop emitting Entry propChanged before ifacesAdded
Even though the deferSignal parameter was set to true in the event log
entry D-Bus interface constructor, propertiesChanged signals would still
be emitted when setting the properties to their initial values. These
were being emitted even before the interfacesAdded signal that is sent
when emit_object_added() is called.
As the code was calling emit_object_added() as soon as it initialized
the properties, it can be deduced that the intended plan was that no
propertiesChanged signals were expected to be sent in the first place.
Fix this by using the sdbusplus functions that take a boolean to skip
sending signals when properties are set to their initial values.
Tested: With this change, propertiesChanged signals are not emitted
before the interfacesAdded signal for the
xyz.openbmc_project.Logging.Entry interface when either creating or
restoring event logs.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I3548fe29a88719232e26dd806e196c156bcf0078
diff --git a/elog_entry.hpp b/elog_entry.hpp
index 3a6b313..db9d9da 100644
--- a/elog_entry.hpp
+++ b/elog_entry.hpp
@@ -69,20 +69,20 @@
EntryIfaces(bus, path.c_str(), true),
parent(parent)
{
- id(idErr);
- severity(severityErr);
- timestamp(timestampErr);
- updateTimestamp(timestampErr);
- message(std::move(msgErr));
- additionalData(std::move(additionalDataErr));
- associations(std::move(objects));
+ id(idErr, true);
+ severity(severityErr, true);
+ timestamp(timestampErr, true);
+ updateTimestamp(timestampErr, true);
+ message(std::move(msgErr), true);
+ additionalData(std::move(additionalDataErr), true);
+ associations(std::move(objects), true);
// Store a copy of associations in case we need to recreate
assocs = associations();
- sdbusplus::xyz::openbmc_project::Logging::server::Entry::resolved(
- false);
+ sdbusplus::xyz::openbmc_project::Logging::server::Entry::resolved(false,
+ true);
- version(fwVersion);
- purpose(VersionPurpose::BMC);
+ version(fwVersion, true);
+ purpose(VersionPurpose::BMC, true);
// Emit deferred signal.
this->emit_object_added();
@@ -101,7 +101,7 @@
EntryIfaces(bus, path.c_str(), true),
parent(parent)
{
- id(entryId);
+ id(entryId, true);
};
/** @brief Set resolution status of the error.