commit f40323d0ad74df4c69b5af8b20b4805b884d4046
author Patrick Williams <patrick@stwcx.xyz> Fri Apr 16 15:35:17 2021 -0500
committer Patrick Williams <patrick@stwcx.xyz> Wed Apr 21 20:06:41 2021 +0000
tree 9c9596a4b4bdc78325adecc784ebbd9061e91f34
parent bb6af8603e70162e45c2b667681f2024c98751ea

fix various warnings

Fix various warnings emitted by -Werror:

    - Unused parameters.
    - Excess semi-colons.
    - Missing initializer.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ifcdac2a66f9cc5f7d7e6571e139c0abdb1c86a8d

elog_entry.cpp

diff --git a/elog_entry.cpp b/elog_entry.cpp
index 9c5d213..8a19d86 100644
--- a/elog_entry.cpp
+++ b/elog_entry.cpp
@@ -64,7 +64,7 @@
     return fd;
 }
 
-void Entry::closeFD(int fd, sdeventplus::source::EventBase& source)
+void Entry::closeFD(int fd, sdeventplus::source::EventBase& /*source*/)
 {
     close(fd);
     fdCloseEventSource.reset();

elog_serialize.cpp

diff --git a/elog_serialize.cpp b/elog_serialize.cpp
index 40c6b74..8af349d 100644
--- a/elog_serialize.cpp
+++ b/elog_serialize.cpp
@@ -12,7 +12,7 @@
 // Register class version
 // From cereal documentation;
 // "This macro should be placed at global scope"
-CEREAL_CLASS_VERSION(phosphor::logging::Entry, CLASS_VERSION);
+CEREAL_CLASS_VERSION(phosphor::logging::Entry, CLASS_VERSION)
 
 namespace phosphor
 {
@@ -27,7 +27,7 @@
  *                       a serialized data across code levels
  */
 template <class Archive>
-void save(Archive& a, const Entry& e, const std::uint32_t version)
+void save(Archive& a, const Entry& e, const std::uint32_t /*version*/)
 {
     a(e.id(), e.severity(), e.timestamp(), e.message(), e.additionalData(),
       e.associations(), e.resolved(), e.version(), e.updateTimestamp());

log_manager.cpp

diff --git a/log_manager.cpp b/log_manager.cpp
index 8fca0a9..90cf1d4 100644
--- a/log_manager.cpp
+++ b/log_manager.cpp
@@ -437,7 +437,7 @@
     }
 }
 
-void Manager::processMetadata(const std::string& errorName,
+void Manager::processMetadata(const std::string& /*errorName*/,
                               const std::vector<std::string>& additionalData,
                               AssociationList& objects) const
 {
@@ -709,6 +709,7 @@
         struct pollfd fds = {
             .fd = fd,
             .events = POLLIN,
+            .revents = 0,
         };
         constexpr auto pollTimeout = 5; // 5 seconds
         rc = poll(&fds, 1, pollTimeout * 1000);

log_manager_main.cpp

diff --git a/log_manager_main.cpp b/log_manager_main.cpp
index 42eb982..7302abd 100644
--- a/log_manager_main.cpp
+++ b/log_manager_main.cpp
@@ -8,7 +8,7 @@
 #include <sdbusplus/server/manager.hpp>
 #include <sdeventplus/event.hpp>
 
-int main(int argc, char* argv[])
+int main(int /*argc*/, char* /*argv*/[])
 {
     auto bus = sdbusplus::bus::new_default();
     auto event = sdeventplus::Event::get_default();