openpower-pels: only fail on hw callouts
After further discussion with the IBM service and manufacturing team, it
was determined that firmware should only be automatically going to
Quiesce and preventing the system boot in QuiesceOnError mode when the
PEL has a hardware callout present (vs. any type of callout).
Tested:
- New unit test case
- Verified that an unrecoverable PEL with only a symbolic FRU and a
maintenance procedure callout did not trigger the Quiesce logic
- Verified that a BMC log with a HW callout still triggers the Quiesce
logic
- Verified a boot in simulation with Quiesce enabled
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I8912d59fd69b699c7da5a44da887cce4e987f6d2
diff --git a/extensions/openpower-pels/pel.hpp b/extensions/openpower-pels/pel.hpp
index 649357f..5edcf10 100644
--- a/extensions/openpower-pels/pel.hpp
+++ b/extensions/openpower-pels/pel.hpp
@@ -287,11 +287,11 @@
}
/**
- * @brief Returns true if any callout is present in the primary SRC
+ * @brief Returns true if a hardware callout is present in the primary SRC
*
- * @return true if callout present, false otherwise
+ * @return true if hardware callout present, false otherwise
*/
- bool isCalloutPresent() const;
+ bool isHwCalloutPresent() const;
/**
* @brief Updates the system info data into HB extended user