commit f904caf45a32a059a8da90421c5b2f63118ea740
author Matt Spinler <spinler@us.ibm.com> Fri May 09 11:46:45 2025 -0500
committer Matt Spinler <spinler@us.ibm.com> Thu May 22 13:41:38 2025 +0000
tree e4111f08c8597cf5f0c02048e5d67b9af817da3d
parent 6f07df3eb16caa595e93f04bad86d0b400fe8048

clang-tidy: Remove unnecessary std::move calls

Change-Id: Ic5a26cfa7c2cb1f993ea4e8ccb30c4a093a75f42
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

extensions/openpower-pels/manager.cpp

diff --git a/extensions/openpower-pels/manager.cpp b/extensions/openpower-pels/manager.cpp
index 7153c12..4cf17e6 100644
--- a/extensions/openpower-pels/manager.cpp
+++ b/extensions/openpower-pels/manager.cpp
@@ -246,7 +246,7 @@
 
     try
     {
-        data = std::move(eselToRawData(esel));
+        data = eselToRawData(esel);
     }
     catch (const std::exception& e)
     {

extensions/openpower-pels/registry.cpp

diff --git a/extensions/openpower-pels/registry.cpp b/extensions/openpower-pels/registry.cpp
index 7ab0c86..ea5dd1d 100644
--- a/extensions/openpower-pels/registry.cpp
+++ b/extensions/openpower-pels/registry.cpp
@@ -562,7 +562,7 @@
     // We finally found the callouts, make the objects.
     for (const auto& callout : calloutLists)
     {
-        calloutEntries.push_back(std::move(makeRegistryCallout(callout)));
+        calloutEntries.push_back(makeRegistryCallout(callout));
     }
 
     return calloutEntries;

test/openpower-pels/pel_test.cpp

diff --git a/test/openpower-pels/pel_test.cpp b/test/openpower-pels/pel_test.cpp
index 67ce75f..c5903c3 100644
--- a/test/openpower-pels/pel_test.cpp
+++ b/test/openpower-pels/pel_test.cpp
@@ -761,11 +761,11 @@
     // This will be trimmed when added
     std::vector<uint8_t> hugeCustomData(17000, 0x42);
 
-    ffdc.emplace_back(std::move(getJSONFFDC(dir)));
-    ffdc.emplace_back(std::move(getCBORFFDC(dir)));
-    ffdc.emplace_back(std::move(getTextFFDC(dir)));
-    ffdc.emplace_back(std::move(getCustomFFDC(dir, customData)));
-    ffdc.emplace_back(std::move(getCustomFFDC(dir, hugeCustomData)));
+    ffdc.emplace_back(getJSONFFDC(dir));
+    ffdc.emplace_back(getCBORFFDC(dir));
+    ffdc.emplace_back(getTextFFDC(dir));
+    ffdc.emplace_back(getCustomFFDC(dir, customData));
+    ffdc.emplace_back(getCustomFFDC(dir, hugeCustomData));
 
     PEL pel{regEntry, 42,   timestamp, phosphor::logging::Entry::Level::Error,
             ad,       ffdc, dataIface, journal};