PEL: Remove Section::validate() virtual func
There is no need for the validate() function that every PEL section uses
to be virtual, because it is always called directly by the class it's
defined in.
Also, cppcheck was complaining that constructors, where validate() is
called, can't call virtual functions anyway.
Tested:
Unit tests pass
Change-Id: I7190a5299baa85f7956963e21189da0f4c62b68a
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
diff --git a/extensions/openpower-pels/extended_user_data.hpp b/extensions/openpower-pels/extended_user_data.hpp
index b2803e2..d819ff2 100644
--- a/extensions/openpower-pels/extended_user_data.hpp
+++ b/extensions/openpower-pels/extended_user_data.hpp
@@ -174,7 +174,7 @@
*
* Updates _valid (in Section) with the results.
*/
- void validate() override;
+ void validate();
/**
* @brief The subsystem creator ID of the code that
diff --git a/extensions/openpower-pels/extended_user_header.hpp b/extensions/openpower-pels/extended_user_header.hpp
index 72c4da4..af8c799 100644
--- a/extensions/openpower-pels/extended_user_header.hpp
+++ b/extensions/openpower-pels/extended_user_header.hpp
@@ -176,7 +176,7 @@
*
* Updates _valid (in Section) with the results.
*/
- void validate() override;
+ void validate();
/**
* @brief Builds the symptom ID
diff --git a/extensions/openpower-pels/failing_mtms.hpp b/extensions/openpower-pels/failing_mtms.hpp
index 4206b6a..71722d9 100644
--- a/extensions/openpower-pels/failing_mtms.hpp
+++ b/extensions/openpower-pels/failing_mtms.hpp
@@ -96,7 +96,7 @@
*
* Updates _valid (in Section) with the results.
*/
- void validate() override;
+ void validate();
/**
* @brief Fills in the object from the stream data
diff --git a/extensions/openpower-pels/generic.hpp b/extensions/openpower-pels/generic.hpp
index 977fd51..ab6a3ce 100644
--- a/extensions/openpower-pels/generic.hpp
+++ b/extensions/openpower-pels/generic.hpp
@@ -75,7 +75,7 @@
*
* Updates _valid (in Section) with the results.
*/
- void validate() override;
+ void validate();
/**
* @brief The section data
diff --git a/extensions/openpower-pels/private_header.hpp b/extensions/openpower-pels/private_header.hpp
index 6ba505f..fc2a6c2 100644
--- a/extensions/openpower-pels/private_header.hpp
+++ b/extensions/openpower-pels/private_header.hpp
@@ -241,7 +241,7 @@
*
* Updates _valid (in Section) with the results.
*/
- void validate() override;
+ void validate();
/**
* @brief The creation time timestamp
diff --git a/extensions/openpower-pels/section.hpp b/extensions/openpower-pels/section.hpp
index ab0ad59..abdd9c1 100644
--- a/extensions/openpower-pels/section.hpp
+++ b/extensions/openpower-pels/section.hpp
@@ -142,13 +142,6 @@
}
/**
- * @brief Used to validate the section.
- *
- * Implemented by derived classes.
- */
- virtual void validate() = 0;
-
- /**
* @brief The section header structure.
*
* Filled in by derived classes.
diff --git a/extensions/openpower-pels/src.hpp b/extensions/openpower-pels/src.hpp
index 781274e..b849c1e 100644
--- a/extensions/openpower-pels/src.hpp
+++ b/extensions/openpower-pels/src.hpp
@@ -428,7 +428,7 @@
*
* Updates _valid (in Section) with the results.
*/
- void validate() override;
+ void validate();
/**
* @brief Get error description from message registry
diff --git a/extensions/openpower-pels/user_data.hpp b/extensions/openpower-pels/user_data.hpp
index 22340db..b4e3d7b 100644
--- a/extensions/openpower-pels/user_data.hpp
+++ b/extensions/openpower-pels/user_data.hpp
@@ -117,7 +117,7 @@
*
* Updates _valid (in Section) with the results.
*/
- void validate() override;
+ void validate();
/**
* @brief The section data
diff --git a/extensions/openpower-pels/user_header.hpp b/extensions/openpower-pels/user_header.hpp
index 024237e..ecad41b 100644
--- a/extensions/openpower-pels/user_header.hpp
+++ b/extensions/openpower-pels/user_header.hpp
@@ -239,7 +239,7 @@
*
* Updates _valid (in Section) with the results.
*/
- void validate() override;
+ void validate();
/**
* @brief Returns the severity value to use from the list