commit 272b453c80faeed47c1d04f05f216a84c791c418
author Patrick Williams <patrick@stwcx.xyz> Sun Dec 04 15:20:26 2022 -0600
committer Patrick Williams <patrick@stwcx.xyz> Mon Dec 05 06:14:28 2022 -0600
tree f02bddc44c53b3a9224c0ebb867cfe2e7ead3e39
parent c109f41ac45addbc8e535d584307336c65e5622c

shellcheck: fix issues and format with beautysh

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib06266cbe243a3e70a4c468c0d4d2c4d2b1f1914

firstboot/first-boot-set-hostname.sh

diff --git a/firstboot/first-boot-set-hostname.sh b/firstboot/first-boot-set-hostname.sh
index eaabb0a..c238962 100644
--- a/firstboot/first-boot-set-hostname.sh
+++ b/firstboot/first-boot-set-hostname.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -eu
+#!/bin/bash -eu
 
 show_error() {
     if [ -n "${JOURNAL_STREAM-}" ]; then
@@ -17,24 +17,21 @@
     INV_ASSET_IFACE='xyz.openbmc_project.Inventory.Decorator.Asset'
     BMC_SN=''
     BMC_ITEM_PATH=$(busctl --no-pager --verbose call \
-                            ${MAPPER_IFACE} \
-                            ${MAPPER_PATH} \
-                            ${MAPPER_IFACE} \
-                            GetSubTree sias \
-                            ${INVENTORY_PATH} 0 1 ${BMC_ITEM_IFACE} \
-                        2>/dev/null | grep ${INVENTORY_PATH} || true)
+            ${MAPPER_IFACE} ${MAPPER_PATH} ${MAPPER_IFACE} \
+            GetSubTree sias \
+            ${INVENTORY_PATH} 0 1 ${BMC_ITEM_IFACE} \
+        2>/dev/null | grep ${INVENTORY_PATH} || true)
 
     # '     STRING "/xyz/openbmc_project/inventory/system/chassis/bmc";'
     BMC_ITEM_PATH=${BMC_ITEM_PATH#*\"}
     BMC_ITEM_PATH=${BMC_ITEM_PATH%\"*}
 
     BMC_ITEM_SERVICE=$(mapper get-service \
-                                ${BMC_ITEM_PATH} 2>/dev/null || true)
+        "${BMC_ITEM_PATH}" 2>/dev/null || true)
 
     if [[ -n "${BMC_ITEM_SERVICE}" ]]; then
-        BMC_SN=$(busctl get-property ${BMC_ITEM_SERVICE} \
-                            ${BMC_ITEM_PATH} \
-                            ${INV_ASSET_IFACE} SerialNumber)
+        BMC_SN=$(busctl get-property "${BMC_ITEM_SERVICE}" \
+            "${BMC_ITEM_PATH}" "${INV_ASSET_IFACE}" SerialNumber)
         # 's "002B0DH1000"'
         BMC_SN=${BMC_SN#*\"}
         BMC_SN=${BMC_SN%\"*}
@@ -47,34 +44,31 @@
 
         NETWORK_ITEM_IFACE='xyz.openbmc_project.Inventory.Item.NetworkInterface'
         NETWORK_ITEM_PATH=$(busctl --no-pager --verbose call \
-                           ${MAPPER_IFACE} \
-                           ${MAPPER_PATH} \
-                           ${MAPPER_IFACE} \
-                           GetSubTree sias \
-                                ${INVENTORY_PATH} 0 1 ${NETWORK_ITEM_IFACE} \
-                    2>/dev/null | grep ${INVENTORY_PATH} || true)
+                ${MAPPER_IFACE} ${MAPPER_PATH} ${MAPPER_IFACE} \
+                GetSubTree sias \
+                ${INVENTORY_PATH} 0 1 ${NETWORK_ITEM_IFACE} \
+            2>/dev/null | grep ${INVENTORY_PATH} || true)
 
         NETWORK_ITEM_PATH=${NETWORK_ITEM_PATH#*\"}
         NETWORK_ITEM_PATH=${NETWORK_ITEM_PATH%\"*}
 
-        NETWORK_ITEM_OBJ=$(mapper get-service ${NETWORK_ITEM_PATH} 2>/dev/null || true)
+        NETWORK_ITEM_OBJ=$(mapper get-service "${NETWORK_ITEM_PATH}" 2>/dev/null || true)
 
         if [[ -z "${NETWORK_ITEM_OBJ}" ]]; then
             show_error 'No Ethernet interface found in the Inventory. Unique hostname not set!'
             exit 1
         fi
 
-        MAC_ADDR=$(busctl get-property ${NETWORK_ITEM_OBJ} \
-                               ${NETWORK_ITEM_PATH} \
-                               ${NETWORK_ITEM_IFACE} MACAddress)
+        MAC_ADDR=$(busctl get-property "${NETWORK_ITEM_OBJ}" \
+            "${NETWORK_ITEM_PATH}" "${NETWORK_ITEM_IFACE}" MACAddress)
 
         # 's "54:52:01:02:03:04"'
         MAC_ADDR=${MAC_ADDR#*\"}
         MAC_ADDR=${MAC_ADDR%\"*}
 
-        hostnamectl set-hostname $(hostname)-${MAC_ADDR}
+        hostnamectl set-hostname "$(hostname)-${MAC_ADDR}"
     else
-        hostnamectl set-hostname $(hostname)-${BMC_SN}
+        hostnamectl set-hostname "$(hostname)-${BMC_SN}"
     fi
 
 }