| commit | 688e9134a83379393ddde6aab0602c64e956153d | [log] [tgz] |
|---|---|---|
| author | Milton Miller <miltonm@us.ibm.com> | Tue Apr 27 03:13:05 2021 -0500 |
| committer | Lei YU <yulei.sh@bytedance.com> | Thu Apr 29 11:38:55 2021 +0800 |
| tree | c03795071eb06177106a0e67770103750d98b95c | |
| parent | cf69740eebf68b76cc5f0509a9b34204dd8bf0a1 [diff] |
usb_ctrl: clean up usb storage configuration The usb storage interface selection had significant factoring during the review process. Here are a few cleanups I found reviewing ecm MAC addresses. - We already handled the default empty + Anything else is Unknown not Illegal - Usually its called a backing file, but use backing storage here + We also support backing devices + The variable name is storage - Specify the default storage interface in one place + By shortening the variable name we can avoid a wrapped line + Instead add a comment on default handling in the setter Signed-off-by: Milton Miller <miltonm@us.ibm.com> Change-Id: I09fad56f3ae4a92c1394e69acd5a82775b409aef
phosphor-misc is a collection of miscellaneous OpenBMC functions that doesn't really fit anywhere else.
If you have a new function in mind to be hosted in phosphor-misc, it is usually a good idea to mention it on the OpenBMC mailing list before writing any code. There might already be an implementation of the desired function or the community may suggest alternatives.
phosphor-misc patches are reviewed using the Gerrit instance at https://gerrit.openbmc-project.xyz.
Please submit patches to Gerrit. More information on using Gerrit can be found here. https://github.com/openbmc/phosphor-misc is a hosting mirror only and GitHub pull requests are not monitored and will not be accepted.
Patch checklist. Please ensure patches adhere to the following guidelines:
For questions or help please come join us on the mailing list or in IRC.