Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-net-ipmid / a71b1bae7abfc7ffb8601a3b5b1fbedcaf6cdc92
commita71b1bae7abfc7ffb8601a3b5b1fbedcaf6cdc92[log] [tgz]
authorVernon Mauery <vernon.mauery@linux.intel.com>Tue Jun 08 15:53:46 2021 -0700
committerVernon Mauery <vernon.mauery@linux.intel.com>Thu Jun 10 14:50:19 2021 -0700
tree4baaa543337d3524bab5255ea979ae7a1faa7165
parent7b645018775b85a0c61148e592d951841809eef9 [diff]
Enforce correct packet lengths

Zero length messages and messages shorter than the expected length
should be rejected. The expected length is the IPMI Msg Length from the
IPMI session header.

Tested:
  # send a zero-length RMCP1.5 packet and a zero-length RMCP2.0 packet
  # RMCP 1.5
  echo -ne "\x06\x00\xff\x07\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00" \
      | nc -w 1 -u $HOST_IP 623
  # RMCP 2.0
  echo -ne "\x06\x00\xff\x07\x06\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00" \
      | nc -w 1 -u $HOST_IP 623

  # send a truncated 255-byte RMCP1.5 packet and a zero-length RMCP2.0 packet
  # RMCP 1.5
  echo -ne "\x06\x00\xff\x07\x00\x00\x00\x00\x00\x00\x00\x00\x00\xff" \
      | nc -w 1 -u $HOST_IP 623
  # RMCP 2.0
  echo -ne "\x06\x00\xff\x07\x06\x00\x00\x00\x00\x00\x00\x00\x00\x00\xff\x00" \
      | nc -w 1 -u $HOST_IP 623

  After each packet sent, verify that netipmid did not crash.

Change-Id: Iec63bae7619e0d3274894e4d98d1f1fb7f082ed6
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
1 file changed
tree: 4baaa543337d3524bab5255ea979ae7a1faa7165
  1. command/
  2. sol/
  3. test/
  4. .clang-format
  5. .gitignore
  6. auth_algo.cpp
  7. auth_algo.hpp
  8. bootstrap.sh
  9. comm_module.cpp
  10. comm_module.hpp
  11. command_table.cpp
  12. command_table.hpp
  13. configure.ac
  14. crypt_algo.cpp
  15. crypt_algo.hpp
  16. endian.hpp
  17. integrity_algo.cpp
  18. integrity_algo.hpp
  19. LICENSE
  20. main.cpp
  21. main.hpp
  22. MAINTAINERS
  23. Makefile.am
  24. message.hpp
  25. message_handler.cpp
  26. message_handler.hpp
  27. message_parsers.cpp
  28. message_parsers.hpp
  29. phosphor-ipmi-net@.service
  30. phosphor-ipmi-net@.socket
  31. prng.hpp
  32. README.md
  33. rmcp.hpp
  34. sd_event_loop.cpp
  35. sd_event_loop.hpp
  36. session.hpp
  37. sessions_manager.cpp
  38. sessions_manager.hpp
  39. socket_channel.hpp
  40. sol_module.cpp
  41. sol_module.hpp
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.