Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-net-ipmid / 5819666c23ee1d01a54fc5fb2c068bb1da1f29c7
commit5819666c23ee1d01a54fc5fb2c068bb1da1f29c7[log] [tgz]
authorJayaprakash Mutyala <mutyalax.jayaprakash@intel.com>Wed Oct 06 22:33:34 2021 +0000
committerVernon Mauery <vernon.mauery@linux.intel.com>Tue Oct 26 17:54:29 2021 +0000
tree890290beb225d9c76835c1d2ef5601e52ef43852
parent1883aea3a3711388cc35753a2e6cf48fa38291f0 [diff]
session_cmds: Validate reserved field content

In "Set Session Privilege Level Command" byte-1’s [7-4] bits and
"CALLBACK" privilege level also reserved. So return
"InvalidFieldRequest" when reserved content is non-zero.

Tested:
Verified using IPMI Command: Set Session Privilege Level Command
Command:  ipmitool -I lanplus -H <BMC-IP> -U <usename> -P <pwd> -C 17
          raw 0x06 0x3B 0x14
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x3b rsp=0xcc): Invalid data field in request
Command:  ipmitool -I lanplus -H <BMC-IP> -U <usename> -P <pwd> -C 17
          raw 0x06 0x3B 0x4
Response: 04
Command:  ipmitool -I lanplus -H <BMC-IP> -U <usename> -P <pwd> -C 17
          raw 0x06 0x3B 0x01 //Set Session Privilege Level for CALLBACK
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x3b rsp=0xcc): Invalid data field in request
Command:  ipmitool -I lanplus -H <BMC-IP> -U <usename> -P <pwd> -C 17
          raw 0x06 0x3B 0x05 //Set Session Privilege Level for OEM
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x3b rsp=0x81): Unknown (0x81)
Command:  ipmitool -I lanplus -H <BMC-IP> -U <usename> -P <pwd> -C 17
          raw 0x06 0x3B 0x06
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x3b rsp=0xcc): Invalid data field in request

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Id76b137112486bb4c617cfa7c861403ce6f6c060
1 file changed
tree: 890290beb225d9c76835c1d2ef5601e52ef43852
  1. command/
  2. sol/
  3. test/
  4. .clang-format
  5. .gitignore
  6. auth_algo.cpp
  7. auth_algo.hpp
  8. bootstrap.sh
  9. comm_module.cpp
  10. comm_module.hpp
  11. command_table.cpp
  12. command_table.hpp
  13. configure.ac
  14. crypt_algo.cpp
  15. crypt_algo.hpp
  16. endian.hpp
  17. integrity_algo.cpp
  18. integrity_algo.hpp
  19. LICENSE
  20. main.cpp
  21. main.hpp
  22. MAINTAINERS
  23. Makefile.am
  24. message.hpp
  25. message_handler.cpp
  26. message_handler.hpp
  27. message_parsers.cpp
  28. message_parsers.hpp
  29. OWNERS
  30. phosphor-ipmi-net@.service
  31. phosphor-ipmi-net@.socket
  32. prng.hpp
  33. README.md
  34. rmcp.hpp
  35. sd_event_loop.cpp
  36. sd_event_loop.hpp
  37. session.hpp
  38. sessions_manager.cpp
  39. sessions_manager.hpp
  40. socket_channel.hpp
  41. sol_module.cpp
  42. sol_module.hpp
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.