Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-net-ipmid / 6d934bd76db405ce2c823fc42aafa8afde242aa8
commit6d934bd76db405ce2c823fc42aafa8afde242aa8[log] [tgz]
authorBenjamin Fair <benjaminfair@google.com>Wed Jul 17 03:20:56 2024 +0000
committerBenjamin Fair <benjaminfair@google.com>Wed Jul 24 20:50:12 2024 +0000
treebfb04b14289ee0ca36fa54b73cb0a1b671ad81f6
parent1499dc2bf906cc295033d02289e67e7c4aee086e [diff]
Remove 'Wants' on phosphor-ipmi-host

The service file for phosphor-ipmi-host already has
WantedBy=multi-user.target, which will instruct systemd to queue a start
task for phosphor-ipmi-host. Having a 'Wants' statement here is
therefore unnecessary.

This duplicate start task can become a problem if phosphor-ipmi-host
fails to start in time and is restarted by systemd. When
phosphor-ipmi-net tries to start later, it can trigger another start
task for phosphor-ipmi-host within the start burst limit, putting
phosphor-ipmi-host into a permanent timeout state.

Tested: With this change, phosphor-ipmi-host no longer has "Start
request repeated too quickly" across 1,000 powercycles.

Signed-off-by: Benjamin Fair <benjaminfair@google.com>
Change-Id: Iabcc57e2ba73522d373d91d02b12fa6e6f389979
1 file changed
tree: bfb04b14289ee0ca36fa54b73cb0a1b671ad81f6
  1. command/
  2. sol/
  3. subprojects/
  4. test/
  5. .clang-format
  6. .gitignore
  7. auth_algo.cpp
  8. auth_algo.hpp
  9. comm_module.cpp
  10. comm_module.hpp
  11. command_table.cpp
  12. command_table.hpp
  13. crypt_algo.cpp
  14. crypt_algo.hpp
  15. endian.hpp
  16. integrity_algo.cpp
  17. integrity_algo.hpp
  18. LICENSE
  19. main.cpp
  20. main.hpp
  21. meson.build
  22. meson.options
  23. message.hpp
  24. message_handler.cpp
  25. message_handler.hpp
  26. message_parsers.cpp
  27. message_parsers.hpp
  28. OWNERS
  29. phosphor-ipmi-net@.service
  30. phosphor-ipmi-net@.socket
  31. prng.hpp
  32. README.md
  33. rmcp.hpp
  34. sd_event_loop.cpp
  35. sd_event_loop.hpp
  36. session.hpp
  37. sessions_manager.cpp
  38. sessions_manager.hpp
  39. socket_channel.hpp
  40. sol_module.cpp
  41. sol_module.hpp
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.