Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-net-ipmid / 779e7e179e48ce5fefb3d85add04b1814a57e9e0
commit779e7e179e48ce5fefb3d85add04b1814a57e9e0[log] [tgz]
authorVernon Mauery <vernon.mauery@linux.intel.com>Tue Jun 08 16:24:45 2021 -0700
committerVernon Mauery <vernon.mauery@linux.intel.com>Sat Jun 12 12:34:49 2021 -0700
treee8b659dbbec411e2d4f6a24dd0ebc2fac1b0c7cd
parent1ab1c6bd6808e9d3d1a5cace45a3f513da7a811e [diff]
Only allow IPMI1.5 for non-session requests

Some IPMI messages must be sent out-of-session in order to set up the
session. In order to be counted as out-of-session, they must use the
0x00000000 session ID. And the only IPMI1.5 packets that are allowed in
OpenBMC are the out-of-session messages used to initiate the RMCP+
sessions. This commit enforces that all messages that contain a non-zero
session ID must be a part of a valid session, which means they must be
RMCP2.0 messages because RMCP1.5 sessions are not supported.

Tested: 1) establish a session; send an RMCP1.5 message with that same
           session ID and see that it gets rejected.
        2) establish a session; send an RMCP2.0 message with a 0 session
           ID and see that it gets rejected.

Change-Id: I01e33f1d8ea9b9c6972238eaaf1b032493f46953
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
2 files changed
tree: e8b659dbbec411e2d4f6a24dd0ebc2fac1b0c7cd
  1. command/
  2. sol/
  3. test/
  4. .clang-format
  5. .gitignore
  6. auth_algo.cpp
  7. auth_algo.hpp
  8. bootstrap.sh
  9. comm_module.cpp
  10. comm_module.hpp
  11. command_table.cpp
  12. command_table.hpp
  13. configure.ac
  14. crypt_algo.cpp
  15. crypt_algo.hpp
  16. endian.hpp
  17. integrity_algo.cpp
  18. integrity_algo.hpp
  19. LICENSE
  20. main.cpp
  21. main.hpp
  22. MAINTAINERS
  23. Makefile.am
  24. message.hpp
  25. message_handler.cpp
  26. message_handler.hpp
  27. message_parsers.cpp
  28. message_parsers.hpp
  29. phosphor-ipmi-net@.service
  30. phosphor-ipmi-net@.socket
  31. prng.hpp
  32. README.md
  33. rmcp.hpp
  34. sd_event_loop.cpp
  35. sd_event_loop.hpp
  36. session.hpp
  37. sessions_manager.cpp
  38. sessions_manager.hpp
  39. socket_channel.hpp
  40. sol_module.cpp
  41. sol_module.hpp
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.