Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-net-ipmid / 7c75c37404f41d8f4a5d03636d46279cfa949804
commit7c75c37404f41d8f4a5d03636d46279cfa949804[log] [tgz]
authorJayaprakash Mutyala <mutyalax.jayaprakash@intel.com>Thu Jan 30 11:58:48 2025 +0000
committerJayaprakash Mutyala <mutyalax.jayaprakash@intel.com>Fri Jan 31 05:10:47 2025 +0000
treeae10c39e6230d9786f26c6fecf5f1c027296619b
parent128d148c4b2fa4ab1c5b83a3c94f23ea58db3cc3 [diff]
Fix netipmid crash due to RMCP_PING activation

The netipmid service occasionally crashes following the changes
introduced in commit #73192.
https://gerrit.openbmc.org/c/openbmc/phosphor-net-ipmid/+/73192
This commit enabled the RMCP_PING definition, which activated
previously dormant code paths under the RMCP_PING flow.

The crash occurs when the inMessage pointer of the rmcpMsgClass
is dereferenced in the Handler destructor, and inMessage is
NULL. To prevent this crash, this commit adds a check to ensure
inMessage is not NULL before accessing.

Signed-off-by: poram srinivasa rao <poramx.srinivasa.rao@intel.com>
Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Ibb14cff628a690acb72aed8c35aff226cfcdcb41
1 file changed
tree: ae10c39e6230d9786f26c6fecf5f1c027296619b
  1. command/
  2. sol/
  3. subprojects/
  4. test/
  5. .clang-format
  6. .gitignore
  7. auth_algo.cpp
  8. auth_algo.hpp
  9. comm_module.cpp
  10. comm_module.hpp
  11. command_table.cpp
  12. command_table.hpp
  13. crypt_algo.cpp
  14. crypt_algo.hpp
  15. endian.hpp
  16. integrity_algo.cpp
  17. integrity_algo.hpp
  18. LICENSE
  19. main.cpp
  20. main.hpp
  21. meson.build
  22. meson.options
  23. message.hpp
  24. message_handler.cpp
  25. message_handler.hpp
  26. message_parsers.cpp
  27. message_parsers.hpp
  28. OWNERS
  29. phosphor-ipmi-net@.service
  30. phosphor-ipmi-net@.socket
  31. prng.hpp
  32. README.md
  33. rmcp.hpp
  34. sd_event_loop.cpp
  35. sd_event_loop.hpp
  36. session.hpp
  37. sessions_manager.cpp
  38. sessions_manager.hpp
  39. socket_channel.hpp
  40. sol_module.cpp
  41. sol_module.hpp
README.md

phosphor-net-ipmid

To Build

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.