Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-net-ipmid / acb8d90b1a2c699352c6b6f5c1555227e7adc004
commitacb8d90b1a2c699352c6b6f5c1555227e7adc004[log] [tgz]
authorAndrew Geissler <geissonator@yahoo.com>Tue Jul 30 10:05:04 2024 -0300
committerPatrick Williams <patrick@stwcx.xyz>Mon Aug 19 10:44:20 2024 -0400
treef5a302af002c3b65433bb02c8a4bc9a911ac0c58
parent916d875577605edbcd30396c91de96d7ce532b5c [diff]
gcc14: fix C++ One Definition Rule

The following error occurs when building with gcc14:
```
| message.hpp:117:8: error: type 'struct Message' violates the C++ One Definition Rule [-Werror=odr]
| message.hpp:117:8: note: a different type is defined in another translation unit
| message.hpp:261:26: note: the first difference of corresponding definitions is field 'payload'
| message.hpp:250:13: note: a field with different name is defined in another translation unit
```

This is because some files that include this header have included
config.h, and some have not. config.h defines the RMCP_PING compile
flag.

Tested:
- Confirmed this now compiles with gcc14

Change-Id: I7f3705bdc21cc05cc7fedb591f198cbf9dc9365d
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
1 file changed
tree: f5a302af002c3b65433bb02c8a4bc9a911ac0c58
  1. command/
  2. sol/
  3. subprojects/
  4. test/
  5. .clang-format
  6. .gitignore
  7. auth_algo.cpp
  8. auth_algo.hpp
  9. comm_module.cpp
  10. comm_module.hpp
  11. command_table.cpp
  12. command_table.hpp
  13. crypt_algo.cpp
  14. crypt_algo.hpp
  15. endian.hpp
  16. integrity_algo.cpp
  17. integrity_algo.hpp
  18. LICENSE
  19. main.cpp
  20. main.hpp
  21. meson.build
  22. meson.options
  23. message.hpp
  24. message_handler.cpp
  25. message_handler.hpp
  26. message_parsers.cpp
  27. message_parsers.hpp
  28. OWNERS
  29. phosphor-ipmi-net@.service
  30. phosphor-ipmi-net@.socket
  31. prng.hpp
  32. README.md
  33. rmcp.hpp
  34. sd_event_loop.cpp
  35. sd_event_loop.hpp
  36. session.hpp
  37. sessions_manager.cpp
  38. sessions_manager.hpp
  39. socket_channel.hpp
  40. sol_module.cpp
  41. sol_module.hpp
README.md

phosphor-net-ipmid

To Build

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.