Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-net-ipmid / 86985d578088607949ed1d09164ccd6060191324
commit86985d578088607949ed1d09164ccd6060191324[log] [tgz]
authorIvan Mikhaylov <i.mikhaylov@yadro.com>Fri Nov 29 12:22:28 2019 +0300
committerIvan Mikhaylov <i.mikhaylov@yadro.com>Mon Jan 13 13:20:08 2020 +0000
tree10e4935890a50a01c3ce0a0d2330b18d849e9ef4
parent46bec0f60a201a644c1f3af4cec2f31da58a0595 [diff]
Fix: fix the access to sin/sin6_addr in getRemoteAddress

inet_ntop using 'remoteSockAddr' instead of casting it to 'sockaddr_in/in6'
structure and getting the field 'sin/sin6_addr' access. As result of this
'getRemoteAddress' returns junk from top of the 'sockaddr_storage' structure.

Tested: Verified by calling 'getRemoteAddress' inside net-ipmi lambda
        handler.

        [handler, this](const boost::system::error_code& ec,
                             const IpmiDbusRspType& response) {
              ...
              std::string raddr =
                      handler->getChannel()->getRemoteAddress();
              some_func_for_put_addr(raddr);
              ...
        }

Signed-off-by: Ivan Mikhaylov <i.mikhaylov@yadro.com>
Change-Id: Ia8ae2763a2ab372c148323974fe33ac44b1d28f0
1 file changed
tree: 10e4935890a50a01c3ce0a0d2330b18d849e9ef4
  1. command/
  2. sol/
  3. test/
  4. .clang-format
  5. .gitignore
  6. auth_algo.cpp
  7. auth_algo.hpp
  8. bootstrap.sh
  9. comm_module.cpp
  10. comm_module.hpp
  11. command_table.cpp
  12. command_table.hpp
  13. configure.ac
  14. crypt_algo.cpp
  15. crypt_algo.hpp
  16. endian.hpp
  17. integrity_algo.cpp
  18. integrity_algo.hpp
  19. LICENSE
  20. main.cpp
  21. main.hpp
  22. MAINTAINERS
  23. Makefile.am
  24. message.hpp
  25. message_handler.cpp
  26. message_handler.hpp
  27. message_parsers.cpp
  28. message_parsers.hpp
  29. phosphor-ipmi-net@.service
  30. phosphor-ipmi-net@.socket
  31. prng.hpp
  32. README.md
  33. rmcp.hpp
  34. sd_event_loop.cpp
  35. sd_event_loop.hpp
  36. session.hpp
  37. sessions_manager.cpp
  38. sessions_manager.hpp
  39. socket_channel.hpp
  40. sol_module.cpp
  41. sol_module.hpp
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.