commit a82e4d3e4dfa452f9752c6bc6e6aa1c5a7c3d247
author Lei YU <yulei.sh@bytedance.com> Wed Jul 13 10:03:20 2022 +0800
committer Lei YU <yulei.sh@bytedance.com> Wed Jul 13 19:55:17 2022 +0800
tree 68dd158c46617b84dbacfb49dcacf1872e4bee0a
parent ce1f4fc56c364b61e54b3ace0730fbce7cf89258

message_parsers: Use const reference where possible

The code was passing std::shared_ptr<xxx> by value (or const value),
which creates unnecessary copies of shared_ptr.

Use `const std::shared_ptr<xxx>&` where possible to eliminate such
copies.

Tested: No code logic changes. Verify the build passes and the net-ipmid
        is working as before.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: Iad6c3b209ab8299fa477784e86c22be19f98a344

message_parsers.hpp

diff --git a/message_parsers.hpp b/message_parsers.hpp
index a992e0a..d6069cc 100644
--- a/message_parsers.hpp
+++ b/message_parsers.hpp
@@ -94,9 +94,9 @@
  *
  * @return IPMI packet on success
  */
-std::vector<uint8_t> flatten(std::shared_ptr<Message> outMessage,
+std::vector<uint8_t> flatten(const std::shared_ptr<Message>& outMessage,
                              SessionHeader authType,
-                             std::shared_ptr<session::Session> session);
+                             const std::shared_ptr<session::Session>& session);
 
 } // namespace parser
 
@@ -134,8 +134,8 @@
  *
  * @return IPMI packet on success
  */
-std::vector<uint8_t> flatten(std::shared_ptr<Message> outMessage,
-                             std::shared_ptr<session::Session> session);
+std::vector<uint8_t> flatten(const std::shared_ptr<Message>& outMessage,
+                             const std::shared_ptr<session::Session>& session);
 
 } // namespace ipmi15parser
 
@@ -182,8 +182,8 @@
  *
  * @return IPMI packet on success
  */
-std::vector<uint8_t> flatten(std::shared_ptr<Message> outMessage,
-                             std::shared_ptr<session::Session> session);
+std::vector<uint8_t> flatten(const std::shared_ptr<Message>& outMessage,
+                             const std::shared_ptr<session::Session>& session);
 
 namespace internal
 {
@@ -196,7 +196,7 @@
  *
  */
 void addSequenceNumber(std::vector<uint8_t>& packet,
-                       std::shared_ptr<session::Session> session);
+                       const std::shared_ptr<session::Session>& session);
 
 /**
  * @brief Verify the integrity data of the incoming IPMI packet
@@ -208,7 +208,7 @@
  *
  */
 bool verifyPacketIntegrity(const std::vector<uint8_t>& packet,
-                           const std::shared_ptr<Message> message,
+                           const std::shared_ptr<Message>& message,
                            size_t payloadLen,
                            const std::shared_ptr<session::Session>& session);
 
@@ -220,7 +220,8 @@
  * @param[in] payloadLen - Length of the IPMI payload
  */
 void addIntegrityData(std::vector<uint8_t>& packet,
-                      const std::shared_ptr<Message> message, size_t payloadLen,
+                      const std::shared_ptr<Message>& message,
+                      size_t payloadLen,
                       const std::shared_ptr<session::Session>& session);
 
 /**
@@ -235,7 +236,7 @@
  */
 std::vector<uint8_t>
     decryptPayload(const std::vector<uint8_t>& packet,
-                   const std::shared_ptr<Message> message, size_t payloadLen,
+                   const std::shared_ptr<Message>& message, size_t payloadLen,
                    const std::shared_ptr<session::Session>& session);
 
 /**
@@ -247,7 +248,7 @@
  * @return on successful completion, return the encrypted payload
  */
 std::vector<uint8_t>
-    encryptPayload(std::shared_ptr<Message> message,
+    encryptPayload(const std::shared_ptr<Message>& message,
                    const std::shared_ptr<session::Session>& session);
 
 } // namespace internal