Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-net-ipmid / ae1fda44032a361874417c4006ddcbd951974399
commitae1fda44032a361874417c4006ddcbd951974399[log] [tgz]
authorVernon Mauery <vernon.mauery@linux.intel.com>Mon Oct 15 12:55:34 2018 -0700
committerVernon Mauery <vernon.mauery@linux.intel.com>Tue Nov 06 15:42:37 2018 -0800
treec179b19c47cdb3ef0114b89385370fc6a144614b
parent9e801a2b5b36acd307606af5eafdb885dfe8daee [diff]
netipmid: use std::shared_ptr instead of weak_ptr/lock

All of the instances of getSession and startSession were assigning the
result to a local shared_ptr via lock on the weak_ptr. It doesn't make
sense to demote the shared_ptr (from the sessionsMap) to a weak_ptr via
the return, only to promote to a shared_ptr again via lock.

Tested-by: running ipmitool -H a.b.c.d -P 0penBmc -I lanplus mc info
           Sessions start and stop, same as before.

Change-Id: Ic10779285891d73ee51115f16ed0000b38d1c52a
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
11 files changed
tree: c179b19c47cdb3ef0114b89385370fc6a144614b
  1. command/
  2. sol/
  3. test/
  4. .clang-format
  5. .gitignore
  6. auth_algo.cpp
  7. auth_algo.hpp
  8. bootstrap.sh
  9. comm_module.cpp
  10. comm_module.hpp
  11. command_table.cpp
  12. command_table.hpp
  13. configure.ac
  14. crypt_algo.cpp
  15. crypt_algo.hpp
  16. endian.hpp
  17. integrity_algo.cpp
  18. integrity_algo.hpp
  19. LICENSE
  20. main.cpp
  21. main.hpp
  22. MAINTAINERS
  23. Makefile.am
  24. message.hpp
  25. message_handler.cpp
  26. message_handler.hpp
  27. message_parsers.cpp
  28. message_parsers.hpp
  29. provider_registration.cpp
  30. provider_registration.hpp
  31. README.md
  32. rmcp.hpp
  33. sd_event_loop.cpp
  34. sd_event_loop.hpp
  35. session.cpp
  36. session.hpp
  37. sessions_manager.cpp
  38. sessions_manager.hpp
  39. settings.cpp
  40. settings.hpp
  41. socket_channel.cpp
  42. socket_channel.hpp
  43. sol_module.cpp
  44. sol_module.hpp
  45. timer.cpp
  46. timer.hpp
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.