Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-net-ipmid / af23add2a2cf73226cdc72af4793fde6357e8932
commitaf23add2a2cf73226cdc72af4793fde6357e8932[log] [tgz]
authorJayaprakash Mutyala <mutyalax.jayaprakash@intel.com>Thu Nov 18 22:29:38 2021 +0000
committerJayaprakash Mutyala <mutyalax.jayaprakash@intel.com>Tue Nov 23 22:29:32 2021 +0000
tree6451d02d2fc14c287c2e95429b68bc27ddad8721
parent5819666c23ee1d01a54fc5fb2c068bb1da1f29c7 [diff]
Fix for closeSession with invalid session ID

Issue: If user trying to closeSession with invalid session ID, response
is incorrect and getting as "Unspecified error" (0xff).

Fix: Handle invalid session ID/Handle using separate try cache blocks
and correct the response. i.e. Return "invalid Session ID in request"
(0x87) if user requests to close invalid session ID. Return "invalid
Session Handle in request" (0x88) if user requests to close invalid
session Handle.

Tested:
Verified using RMCPP command.
Command : ipmitool -I lanplus -H <BMC-IP> -U <Username> -P <pwd> -C 17
          raw 0x06 0x3C 0x87 0x00 0xEC 0x8E //Close session command
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x3c rsp=0x87): Unknown (0x87)
Command : ipmitool -I lanplus -H <BMC-IP> -U <Username> -P <pwd> -C 17
          raw 0x06 0x3C 0x0 0x0 0x0 0x0 0x80
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x3c rsp=0x88): Unknown (0x88)

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I97f57c7cc48efb17e561985b1f4964a8a15bf30e
1 file changed
tree: 6451d02d2fc14c287c2e95429b68bc27ddad8721
  1. command/
  2. sol/
  3. test/
  4. .clang-format
  5. .gitignore
  6. auth_algo.cpp
  7. auth_algo.hpp
  8. bootstrap.sh
  9. comm_module.cpp
  10. comm_module.hpp
  11. command_table.cpp
  12. command_table.hpp
  13. configure.ac
  14. crypt_algo.cpp
  15. crypt_algo.hpp
  16. endian.hpp
  17. integrity_algo.cpp
  18. integrity_algo.hpp
  19. LICENSE
  20. main.cpp
  21. main.hpp
  22. MAINTAINERS
  23. Makefile.am
  24. message.hpp
  25. message_handler.cpp
  26. message_handler.hpp
  27. message_parsers.cpp
  28. message_parsers.hpp
  29. OWNERS
  30. phosphor-ipmi-net@.service
  31. phosphor-ipmi-net@.socket
  32. prng.hpp
  33. README.md
  34. rmcp.hpp
  35. sd_event_loop.cpp
  36. sd_event_loop.hpp
  37. session.hpp
  38. sessions_manager.cpp
  39. sessions_manager.hpp
  40. socket_channel.hpp
  41. sol_module.cpp
  42. sol_module.hpp
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.