Fix IPMI SEL reservations and cancellations
Per the IPMI Spec, the SEL must be reserved to
Delete an entry
Clear the SEL
Get a partial entry
Add a partial entry
The current SEL reservation must be cancelled when
A SEL entry is added
A SEL entry is deleted
The SEL is cleared
The device is reset
A new reservation is requested
This change adds a reservation status to track when a reservation
is active and a method to cancel the current reservation, and it
uses that to cancel the reservation in the Delete, Clear, and Add
SEL methods.
Change-Id: I13c88f80ec83c090ca83c1b0a8a5e1499303536b
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
diff --git a/main.cpp b/main.cpp
index d79572c..78a24d2 100644
--- a/main.cpp
+++ b/main.cpp
@@ -38,7 +38,8 @@
std::unique_ptr<phosphor::ipmi::Timer> networkTimer = nullptr;
FILE* ipmidbus = nullptr;
-unsigned short g_sel_reserve = 0xFFFF;
+static unsigned short selReservationID = 0xFFFF;
+static bool selReservationValid = false;
sd_bus_slot* ipmid_slot = nullptr;
/*
@@ -60,9 +61,31 @@
/*
* @brief Required by apphandler IPMI Provider Library
*/
-unsigned short get_sel_reserve_id()
+unsigned short reserveSel(void)
{
- return g_sel_reserve;
+ // IPMI spec, Reservation ID, the value simply increases against each
+ // execution of the Reserve SEL command.
+ if (++selReservationID == 0) {
+ selReservationID = 1;
+ }
+ selReservationValid = true;
+ return selReservationID;
+}
+
+/*
+ * @brief Required by apphandler IPMI Provider Library
+ */
+bool checkSELReservation(unsigned short id)
+{
+ return (selReservationValid && selReservationID == id);
+}
+
+/*
+ * @brief Required by apphandler IPMI Provider Library
+ */
+void cancelSELReservation(void)
+{
+ selReservationValid = false;
}
int main(int i_argc, char* i_argv[])